Skip to content

Add stubs to typeshed #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chadrik opened this issue Jan 5, 2018 · 8 comments
Closed

Add stubs to typeshed #319

chadrik opened this issue Jan 5, 2018 · 8 comments

Comments

@chadrik
Copy link
Contributor

chadrik commented Jan 5, 2018

As per the typshed contribution docs, this issue is to request permission to add attrs to the python typeshed. Also, it doubles as a way to let you know that @euresti and I are ready for you to review #238.

@hynek
Copy link
Member

hynek commented Jan 5, 2018

This gives them the opportunity to consider adopting type hints directly in their codebase (which you should prefer to external type stubs).

That...doesn’t really make sense in mypy‘s current Modus operandi, does it?

@chadrik
Copy link
Contributor Author

chadrik commented Jan 5, 2018

That...doesn’t really make sense in mypy‘s current Modus operandi, does it?

I believe that is correct. Mypy searches for stubs within a list of paths defined by MYPYPATH, ignores PYTHONPATH, and explicitly advises against pointing MYPYPATH at site-packages. So for all intents and purposes, python's package distribution (i.e. pip) and PEP484 stubs are at odds with each other. Until PEP 561 is complete (slated for 3.7) we have the typeshed.

@hynek
Copy link
Member

hynek commented Jan 5, 2018

Well, yolo away then.

@chadrik
Copy link
Contributor Author

chadrik commented Jan 5, 2018

You only YOLO once ;)

@wsanchez
Copy link

wsanchez commented Jan 8, 2018

Agreed on typeshed being the next step here.

@hynek
Copy link
Member

hynek commented Jan 14, 2018

Can this be closed?

@euresti
Copy link
Contributor

euresti commented Jan 14, 2018

All @chadrik needs is for this to say that the maintainers give permission to put it in typeshed. Closing is probably ok.

@hynek
Copy link
Member

hynek commented Jan 14, 2018

Permission is granted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants