Bedevere should label "awaiting merge" after a core review

[hugovk]

Steps to reproduce

1. PR has "awaiting review" label
2. A core dev approves it

Actual result

Bedevere removes "awaiting review" and adds "awaiting core review"

(This is what should happen when a non-core dev approves.)

Expected result

Bedevere removes "awaiting review" and adds "awaiting merge"

For example:

And:

See also

State diagram at https://github.com/python/bedevere#pr-state-machine

[Mariatta]

I'll take a look tomorrow.

[pradyunsg]

@Mariatta and I investigated this yesterday, and this has been resolved.

For posterity: The bot was recently migrated from a GitHub (bot) account to a GitHub App. During this migration, insufficient permissions were provided to the bedevere GitHub App -- it did not have the permission to query the membership to teams within the python organisation. This meant that the bot could not determine who is a core team member, and would label PRs as if everyone reviewing PRs is not a core developer.

Adding the relevant permission resolved this issue.

[hugovk]

Thanks both!