Skip to content

Commit c51d56f

Browse files
authored
Issue #419: Only add Tier-1 and Tier-2 builders to Release Status (#422)
1 parent f14e79e commit c51d56f

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

master/custom/builders.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,17 @@
4444
Wasm32WASIBuild,
4545
)
4646

47+
# A builder can be marked as stable when at least the 10 latest builds are
48+
# successful, but it's way better to wait at least for at least one week of
49+
# successful builds before considering to mark a builder as stable.
4750
STABLE = "stable"
51+
52+
# New builders should always be marked as unstable. If a stable builder starts
53+
# to fail randomly, it can be downgraded to unstable if it is not a Tier-1 or
54+
# Tier-2 builder.
4855
UNSTABLE = "unstable"
56+
57+
# https://peps.python.org/pep-0011/ defines Platfom Support Tiers
4958
TIER_1 = "tier-1"
5059
TIER_2 = "tier-2"
5160
TIER_3 = "tier-3"

master/master.cfg

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ from custom.builders import (
5858
STABLE,
5959
DAILYBUILDERS,
6060
ONLY_MAIN_BRANCH,
61+
TIER_1, TIER_2,
6162
) # noqa: E402
6263

6364
def set_up_sentry():
@@ -198,6 +199,7 @@ def is_important_change(change):
198199

199200

200201
github_status_builders = []
202+
release_status_builders = []
201203
mail_status_builders = []
202204

203205
# Regular builders
@@ -252,6 +254,9 @@ for branch_num, (git_url, branchname, git_branch) in enumerate(git_branches):
252254
# disable GitHub notifications for unstable builders
253255
if stability == STABLE:
254256
github_status_builders.append(buildername)
257+
# Only Tier-1 and Tier-2 builders can block a release
258+
if tier in (TIER_1, TIER_2):
259+
release_status_builders.append(buildername)
255260
tags = [branchname, stability,] + getattr(f, "tags", [])
256261
if tier:
257262
tags.append(tier)
@@ -521,7 +526,7 @@ c['www']['plugins']['wsgi_dashboards'] = [
521526
{
522527
'name': 'release_status',
523528
'caption': 'Release Status',
524-
'app': get_release_status_app(github_status_builders),
529+
'app': get_release_status_app(release_status_builders),
525530
'order': 2,
526531
'icon': 'rocket'
527532
}

0 commit comments

Comments
 (0)