Skip to content

Commit 22245e4

Browse files
Address review comments.
1 parent 948747a commit 22245e4

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

Lib/test/test_float.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -737,8 +737,9 @@ def test_format_testfile(self):
737737
self.assertEqual(fmt % f, rhs)
738738
self.assertEqual(fmt % -f, '-' + rhs)
739739
if fmt != '%r':
740-
self.assertEqual(format(f, fmt[1:]), rhs)
741-
self.assertEqual(format(-f, fmt[1:]), '-' + rhs)
740+
fmt2 = fmt[1:]
741+
self.assertEqual(format(f, fmt2), rhs)
742+
self.assertEqual(format(-f, fmt2), '-' + rhs)
742743

743744
def test_issue5864(self):
744745
self.assertEqual(format(123.456, '.4'), '123.5')

Lib/test/test_fractions.py

+9-5
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import operator
88
import fractions
99
import functools
10+
import os
1011
import sys
1112
import typing
1213
import unittest
@@ -15,6 +16,9 @@
1516
from pickle import dumps, loads
1617
F = fractions.Fraction
1718

19+
#locate file with float format test values
20+
test_dir = os.path.dirname(__file__) or os.curdir
21+
format_testfile = os.path.join(test_dir, 'formatfloat_testcases.txt')
1822

1923
class DummyFloat(object):
2024
"""Dummy float class for testing comparisons with Fractions"""
@@ -1222,7 +1226,6 @@ def test_invalid_formats(self):
12221226

12231227
@requires_IEEE_754
12241228
def test_float_format_testfile(self):
1225-
from test.test_float import format_testfile
12261229
with open(format_testfile, encoding="utf-8") as testfile:
12271230
for line in testfile:
12281231
if line.startswith('--'):
@@ -1235,14 +1238,15 @@ def test_float_format_testfile(self):
12351238
fmt, arg = lhs.split()
12361239
if fmt == '%r':
12371240
continue
1241+
fmt2 = fmt[1:]
12381242
with self.subTest(fmt=fmt, arg=arg):
12391243
f = F(float(arg))
1240-
self.assertEqual(format(f, fmt[1:]), rhs)
1244+
self.assertEqual(format(f, fmt2), rhs)
12411245
if f: # skip negative zero
1242-
self.assertEqual(format(-f, fmt[1:]), '-' + rhs)
1246+
self.assertEqual(format(-f, fmt2), '-' + rhs)
12431247
f = F(arg)
1244-
self.assertEqual(float(format(f, fmt[1:])), float(rhs))
1245-
self.assertEqual(float(format(-f, fmt[1:])), float('-' + rhs))
1248+
self.assertEqual(float(format(f, fmt2)), float(rhs))
1249+
self.assertEqual(float(format(-f, fmt2)), float('-' + rhs))
12461250

12471251

12481252
if __name__ == '__main__':

0 commit comments

Comments
 (0)