Skip to content

Commit 3c6173c

Browse files
bpo-46616: Ensures test_importlib.test_windows cleans up registry keys after completion (GH-31086)
(cherry picked from commit 89a0a90) Co-authored-by: Steve Dower <[email protected]>
1 parent 8d239bf commit 3c6173c

File tree

2 files changed

+16
-3
lines changed

2 files changed

+16
-3
lines changed

Lib/test/test_importlib/test_windows.py

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,17 +41,28 @@ def setup_module(machinery, name, path=None):
4141
root = machinery.WindowsRegistryFinder.REGISTRY_KEY
4242
key = root.format(fullname=name,
4343
sys_version='%d.%d' % sys.version_info[:2])
44+
base_key = "Software\\Python\\PythonCore\\{}.{}".format(
45+
sys.version_info.major, sys.version_info.minor)
46+
assert key.casefold().startswith(base_key.casefold()), (
47+
"expected key '{}' to start with '{}'".format(key, base_key))
4448
try:
4549
with temp_module(name, "a = 1") as location:
50+
try:
51+
OpenKey(HKEY_CURRENT_USER, base_key)
52+
if machinery.WindowsRegistryFinder.DEBUG_BUILD:
53+
delete_key = os.path.dirname(key)
54+
else:
55+
delete_key = key
56+
except OSError:
57+
delete_key = base_key
4658
subkey = CreateKey(HKEY_CURRENT_USER, key)
4759
if path is None:
4860
path = location + ".py"
4961
SetValue(subkey, "", REG_SZ, path)
5062
yield
5163
finally:
52-
if machinery.WindowsRegistryFinder.DEBUG_BUILD:
53-
key = os.path.dirname(key)
54-
delete_registry_tree(HKEY_CURRENT_USER, key)
64+
if delete_key:
65+
delete_registry_tree(HKEY_CURRENT_USER, delete_key)
5566

5667

5768
@unittest.skipUnless(sys.platform.startswith('win'), 'requires Windows')
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
Ensures ``test_importlib.test_windows`` cleans up registry keys after
2+
completion.

0 commit comments

Comments
 (0)