Skip to content

Commit 643e889

Browse files
committed
More specific fix
1 parent 89144bf commit 643e889

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

Lib/test/test_pydoc/test_pydoc.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1303,6 +1303,11 @@ def test_apropos_with_unreadable_dir(self):
13031303
@os_helper.skip_unless_working_chmod
13041304
def test_apropos_empty_doc(self):
13051305
pkgdir = os.path.join(TESTFN, 'walkpkg')
1306+
if support.is_emscripten:
1307+
# Emscripten's readdir implementation is buggy on directories
1308+
# with read permission but no execute permission.
1309+
old_umask = os.umask(0)
1310+
self.addCleanup(os.umask, old_umask)
13061311
os.mkdir(pkgdir)
13071312
self.addCleanup(rmtree, pkgdir)
13081313
init_path = os.path.join(pkgdir, '__init__.py')

Tools/wasm/emscripten/__main__.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -263,10 +263,6 @@ def configure_emscripten_python(context, working_dir):
263263
REALPATH=abs_path
264264
fi
265265
266-
# Set umask to 0. The buildbot seems to run sometimes with a umask
267-
# of 0o077 which causes one test to fail.
268-
umask 0
269-
270266
# We compute our own path, not following symlinks and pass it in so that
271267
# node_entry.mjs can set sys.executable correctly.
272268
# Intentionally allow word splitting on NODEFLAGS.

0 commit comments

Comments
 (0)