Skip to content

Commit 893c3b7

Browse files
[3.10] gh-108342: Break ref cycle in SSLSocket._create() exc (GH-108344) (#108350)
Explicitly break a reference cycle when SSLSocket._create() raises an exception. Clear the variable storing the exception, since the exception traceback contains the variables and so creates a reference cycle. This test leak was introduced by the test added for the fix of GH-108310. (cherry picked from commit 64f9935) Co-authored-by: Victor Stinner <[email protected]>
1 parent 1c937e5 commit 893c3b7

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

Lib/ssl.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1079,7 +1079,11 @@ def _create(cls, sock, server_side=False, do_handshake_on_connect=True,
10791079
self.close()
10801080
except OSError:
10811081
pass
1082-
raise notconn_pre_handshake_data_error
1082+
try:
1083+
raise notconn_pre_handshake_data_error
1084+
finally:
1085+
# Explicitly break the reference cycle.
1086+
notconn_pre_handshake_data_error = None
10831087
else:
10841088
connected = True
10851089

0 commit comments

Comments
 (0)