Skip to content

Commit b97f25b

Browse files
hugovkCAM-Gerlach
andauthored
Apply suggestions from code review
Co-authored-by: C.A.M. Gerlach <[email protected]>
1 parent 238dfc2 commit b97f25b

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

.github/workflows/doc.yml

+5-4
Original file line numberDiff line numberDiff line change
@@ -57,20 +57,21 @@ jobs:
5757
- name: Get list of changed files
5858
id: changed_files
5959
uses: Ana06/[email protected]
60-
- name: 'Build changed files with nitpicks'
60+
- name: 'Build changed files in nit-picky mode'
6161
continue-on-error: true
6262
run: |
6363
# Mark files the pull request modified
6464
touch ${{ steps.changed_files.outputs.added_modified }}
65-
# Build docs with the '-n' (nit-picky) option, convert warnings
65+
# Build docs with the '-n' (nit-picky) option; convert warnings to annotations
6666
make -C Doc/ PYTHON=../python SPHINXOPTS="-q -n --keep-going" html 2>&1 |
6767
python Doc/tools/warnings-to-gh-actions.py
6868
69-
# Ensure some files always pass Sphinx nitpicks (missing references)
70-
- name: 'Build others with nitpicks'
69+
# Ensure some files always pass Sphinx nit-picky mode (no missing references)
70+
- name: 'Build known-good files in nit-picky mode'
7171
run: |
7272
# Mark files that must pass nit-picky
7373
touch Doc/whatsnew/3.12.rst
74+
touch Doc/library/sqlite3.rst
7475
# Build docs with the '-n' (nit-picky) option, convert warnings to errors (-W)
7576
make -C Doc/ PYTHON=../python SPHINXOPTS="-q -n -W --keep-going" html 2>&1
7677

Doc/tools/warnings-to-gh-actions.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
#!/usr/bin/env python3
22

3-
"""Convert Sphinx warning messages to GitHub Actions
3+
"""
4+
Convert Sphinx warning messages to GitHub Actions.
45
56
Converts lines like:
67
.../Doc/library/cgi.rst:98: WARNING: reference target not found
@@ -12,8 +13,8 @@
1213
see: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-a-warning-message
1314
"""
1415

15-
import sys
1616
import re
17+
import sys
1718

1819
pattern = re.compile(r'(?P<file>[^:]+):(?P<line>\d+): WARNING: (?P<msg>.+)')
1920

Doc/whatsnew/3.12.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -1003,7 +1003,7 @@ Deprecated
10031003
:c:type:`PyConfig` instead.
10041004
(Contributed by Victor Stinner in :gh:`77782`.)
10051005

1006-
* Creating :const:`immutable types <Py_TPFLAGS_IMMUTABLETYPE>` with mutable
1006+
* Creating immutable types (:const:`Py_TPFLAGS_IMMUTABLETYPE`) with mutable
10071007
bases is deprecated and will be disabled in Python 3.14.
10081008

10091009
* The ``structmember.h`` header is deprecated, though it continues to be

0 commit comments

Comments
 (0)