Skip to content

Commit f1502d0

Browse files
gronkepfmoore
authored andcommitted
bpo-31569: correct PCBuild/ case to PCbuild/ in build scripts and docs (GH-3711)
1 parent 8110dbd commit f1502d0

22 files changed

+44
-43
lines changed

.github/CODEOWNERS

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ Python/bootstrap_hash.c @python/crypto-team
3535

3636
# Windows
3737
/PC/ @python/windows-team
38-
/PCBuild/ @python/windows-team
38+
/PCbuild/ @python/windows-team
3939

4040
# Windows installer packages
4141
/Tools/msi/ @python/windows-team

.github/appveyor.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ only_commits:
2828
- Modules/
2929
- Objects/
3030
- PC/
31-
- PCBuild/
31+
- PCbuild/
3232
- Parser/
3333
- Programs/
3434
- Python/

Doc/distutils/builtdist.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@ Python itself for the platform you are targeting - it is not possible from a
368368
binary installation of Python (as the .lib etc file for other platforms are
369369
not included.) In practice, this means the user of a 32 bit operating
370370
system will need to use Visual Studio 2008 to open the
371-
:file:`PCBuild/PCbuild.sln` solution in the Python source tree and build the
371+
:file:`PCbuild/PCbuild.sln` solution in the Python source tree and build the
372372
"x64" configuration of the 'pythoncore' project before cross-compiling
373373
extensions is possible.
374374

Doc/library/test.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ options, run :program:`python -m test -h`.
186186
Some other ways to execute the regression tests depend on what platform the
187187
tests are being executed on. On Unix, you can run :program:`make test` at the
188188
top-level directory where Python was built. On Windows,
189-
executing :program:`rt.bat` from your :file:`PCBuild` directory will run all
189+
executing :program:`rt.bat` from your :file:`PCbuild` directory will run all
190190
regression tests.
191191

192192

Doc/make.bat

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ pushd %~dp0
55

66
set this=%~n0
77

8-
call ..\PCBuild\find_python.bat %PYTHON%
8+
call ..\PCbuild\find_python.bat %PYTHON%
99
if not defined SPHINXBUILD if defined PYTHON (
1010
%PYTHON% -c "import sphinx" > nul 2> nul
1111
if errorlevel 1 (

Lib/distutils/sysconfig.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
BASE_EXEC_PREFIX = os.path.normpath(sys.base_exec_prefix)
2424

2525
# Path to the base directory of the project. On Windows the binary may
26-
# live in project/PCBuild/win32 or project/PCBuild/amd64.
26+
# live in project/PCbuild/win32 or project/PCbuild/amd64.
2727
# set for cross builds
2828
if "_PYTHON_PROJECT_BASE" in os.environ:
2929
project_base = os.path.abspath(os.environ["_PYTHON_PROJECT_BASE"])
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Correct PCBuild/ case to PCbuild/ in build scripts and documentation.

PC/bdist_wininst/bdist_wininst.vcxproj

+2-2
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
<RootNamespace>wininst</RootNamespace>
4040
<SupportPGO>false</SupportPGO>
4141
</PropertyGroup>
42-
<Import Project="..\..\PCBuild\python.props" />
42+
<Import Project="..\..\PCbuild\python.props" />
4343
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
4444
<PropertyGroup Label="Configuration">
4545
<ConfigurationType>Application</ConfigurationType>
@@ -51,7 +51,7 @@
5151
</ImportGroup>
5252
<ImportGroup Label="PropertySheets">
5353
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
54-
<Import Project="..\..\PCBuild\pyproject.props" />
54+
<Import Project="..\..\PCbuild\pyproject.props" />
5555
</ImportGroup>
5656
<PropertyGroup>
5757
<_ProjectFileVersion>10.0.30319.1</_ProjectFileVersion>

PC/bdist_wininst/build.bat

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
setlocal
33

44
set D=%~dp0
5-
set PCBUILD=%~dp0..\..\PCBuild\
5+
set PCBUILD=%~dp0..\..\PCbuild\
66

77

88
echo Building Lib\distutils\command\wininst-xx.0.exe

PC/launcher.c

+4-4
Original file line numberDiff line numberDiff line change
@@ -169,11 +169,11 @@ static size_t num_installed_pythons = 0;
169169

170170
static wchar_t * location_checks[] = {
171171
L"\\",
172-
L"\\PCBuild\\win32\\",
173-
L"\\PCBuild\\amd64\\",
172+
L"\\PCbuild\\win32\\",
173+
L"\\PCbuild\\amd64\\",
174174
/* To support early 32bit versions of Python that stuck the build binaries
175-
* directly in PCBuild... */
176-
L"\\PCBuild\\",
175+
* directly in PCbuild... */
176+
L"\\PCbuild\\",
177177
NULL
178178
};
179179

PCbuild/python.props

+5-5
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,13 @@
3232
<PySourcePath Condition="!HasTrailingSlash($(PySourcePath))">$(PySourcePath)\</PySourcePath>
3333

3434
<!-- Directory where build outputs are put -->
35-
<BuildPath32 Condition="'$(Py_OutDir)' == ''">$(PySourcePath)PCBuild\win32\</BuildPath32>
35+
<BuildPath32 Condition="'$(Py_OutDir)' == ''">$(PySourcePath)PCbuild\win32\</BuildPath32>
3636
<BuildPath32 Condition="'$(Py_OutDir)' != ''">$(Py_OutDir)\win32\</BuildPath32>
37-
<BuildPath64 Condition="'$(Py_OutDir)' == ''">$(PySourcePath)PCBuild\amd64\</BuildPath64>
37+
<BuildPath64 Condition="'$(Py_OutDir)' == ''">$(PySourcePath)PCbuild\amd64\</BuildPath64>
3838
<BuildPath64 Condition="'$(Py_OutDir)' != ''">$(Py_OutDir)\amd64\</BuildPath64>
3939
<BuildPath Condition="'$(ArchName)' == 'win32'">$(BuildPath32)</BuildPath>
4040
<BuildPath Condition="'$(ArchName)' == 'amd64'">$(BuildPath64)</BuildPath>
41-
<BuildPath Condition="'$(BuildPath)' == ''">$(PySourcePath)PCBuild\$(ArchName)\</BuildPath>
41+
<BuildPath Condition="'$(BuildPath)' == ''">$(PySourcePath)PCbuild\$(ArchName)\</BuildPath>
4242
<BuildPath Condition="!HasTrailingSlash($(BuildPath))">$(BuildPath)\</BuildPath>
4343
<BuildPath Condition="$(Configuration) == 'PGInstrument'">$(BuildPath)instrumented\</BuildPath>
4444

@@ -118,11 +118,11 @@
118118
Override the version number when building by specifying OverrideVersion.
119119
For example:
120120
121-
PCBuild\build.bat "/p:OverrideVersion=3.5.2a1"
121+
PCbuild\build.bat "/p:OverrideVersion=3.5.2a1"
122122
123123
Use the -V option to check your version is valid:
124124
125-
PCBuild\build.bat -V "/p:OverrideVersion=3.5.2a1"
125+
PCbuild\build.bat -V "/p:OverrideVersion=3.5.2a1"
126126
PythonVersionNumber: 3.5.2
127127
PythonVersion: 3.5.2a1
128128
PythonVersionHex: 0x030502A1

Tools/freeze/extensions_win32.ini

+9-9
Original file line numberDiff line numberDiff line change
@@ -26,34 +26,34 @@
2626
; If you need others, add them here
2727

2828
[_socket]
29-
dsp=%PYTHONPREFIX%\PCBuild\_socket.dsp
29+
dsp=%PYTHONPREFIX%\PCbuild\_socket.dsp
3030

3131
[_sre]
32-
dsp=%PYTHONPREFIX%\PCBuild\_sre.dsp
32+
dsp=%PYTHONPREFIX%\PCbuild\_sre.dsp
3333

3434
[unicodedata]
35-
dsp=%PYTHONPREFIX%\PCBuild\unicodedata.dsp
35+
dsp=%PYTHONPREFIX%\PCbuild\unicodedata.dsp
3636

3737
[mmap]
38-
dsp=%PYTHONPREFIX%\PCBuild\mmap.dsp
38+
dsp=%PYTHONPREFIX%\PCbuild\mmap.dsp
3939

4040
[winsound]
41-
dsp=%PYTHONPREFIX%\PCBuild\winsound.dsp
41+
dsp=%PYTHONPREFIX%\PCbuild\winsound.dsp
4242
libs=winmm.lib
4343

4444
[parser]
45-
dsp=%PYTHONPREFIX%\PCBuild\parser.dsp
45+
dsp=%PYTHONPREFIX%\PCbuild\parser.dsp
4646

4747
[select]
48-
dsp=%PYTHONPREFIX%\PCBuild\select.dsp
48+
dsp=%PYTHONPREFIX%\PCbuild\select.dsp
4949

5050
[zlib]
51-
dsp=%PYTHONPREFIX%\PCBuild\zlib.dsp
51+
dsp=%PYTHONPREFIX%\PCbuild\zlib.dsp
5252
cl=/I %PYTHONPREFIX%\..\zlib-1.1.4 /D _WINDOWS /D WIN32
5353
libs=%PYTHONPREFIX%\..\zlib-1.1.4\zlib.lib /nodefaultlib:libc
5454

5555
[winreg]
56-
dsp=%PYTHONPREFIX%\PCBuild\winreg.dsp
56+
dsp=%PYTHONPREFIX%\PCbuild\winreg.dsp
5757
libs=advapi32.lib
5858

5959

Tools/msi/README.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -64,15 +64,15 @@ Building the Installer
6464

6565
Before building the installer, download extra build dependencies using
6666
Tools\msi\get_externals.bat. (Note that this is in addition to the
67-
similarly named file in PCBuild.)
67+
similarly named file in PCbuild.)
6868

6969
For testing, the installer should be built with the Tools/msi/build.bat
7070
script:
7171

7272
build.bat [-x86] [-x64] [--doc] [--test-marker] [--pack]
7373

7474
This script will build the required configurations of Python and
75-
generate an installer layout in PCBuild/(win32|amd64)/en-us.
75+
generate an installer layout in PCbuild/(win32|amd64)/en-us.
7676

7777
Specify -x86 and/or -x64 to build for each platform. If neither is
7878
specified, both platforms will be built. Currently, both the debug and

Tools/msi/build.bat

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
@echo off
22
setlocal
33
set D=%~dp0
4-
set PCBUILD=%D%..\..\PCBuild\
4+
set PCBUILD=%D%..\..\PCbuild\
55

66
set BUILDX86=
77
set BUILDX64=

Tools/msi/buildrelease.bat

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ rem {msi} MSI filename core.msi
2828
set DOWNLOAD_URL=https://www.python.org/ftp/python/{version}/{arch}{releasename}/{msi}
2929

3030
set D=%~dp0
31-
set PCBUILD=%D%..\..\PCBuild\
31+
set PCBUILD=%D%..\..\PCbuild\
3232
if "%Py_OutDir%"=="" set Py_OutDir=%PCBUILD%
3333
set EXTERNALS=%D%..\..\externals\windows-installer\
3434

Tools/msi/exe/exe.wixproj

+3-3
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
</Target>
4646

4747
<Target Name="_MergeMiscNewsWithBlurb" AfterTargets="PrepareForBuild" Condition="$(Blurb) != '' and !Exists('$(PySourcePath)Misc\NEWS')">
48-
<Exec Command="$(Blurb) merge -f &quot;$(BuildPath)NEWS.txt&quot;" WorkingDirectory="$(PCBuild)" />
48+
<Exec Command="$(Blurb) merge -f &quot;$(BuildPath)NEWS.txt&quot;" WorkingDirectory="$(PCbuild)" />
4949
</Target>
5050

5151
<Target Name="_MergeMiscNewsWithPython" AfterTargets="PrepareForBuild" Condition="$(Blurb) == '' and !Exists('$(PySourcePath)Misc\NEWS')">
@@ -58,8 +58,8 @@
5858
<HostPython>@(HostPython)</HostPython>
5959
<HostPython Condition="$(HostPython.Contains(';'))">$(HostPython.Remove($(HostPython.IndexOf(';'))))</HostPython>
6060
</PropertyGroup>
61-
<Exec Command="&quot;$(HostPython)&quot; -m pip install -U blurb" WorkingDirectory="$(PCBuild)" />
62-
<Exec Command="&quot;$(HostPython)&quot; -m blurb merge -f &quot;$(BuildPath)NEWS.txt&quot;" WorkingDirectory="$(PCBuild)" />
61+
<Exec Command="&quot;$(HostPython)&quot; -m pip install -U blurb" WorkingDirectory="$(PCbuild)" />
62+
<Exec Command="&quot;$(HostPython)&quot; -m blurb merge -f &quot;$(BuildPath)NEWS.txt&quot;" WorkingDirectory="$(PCbuild)" />
6363
</Target>
6464

6565
<Import Project="..\msi.targets" />

Tools/msi/launcher/launcher.wixproj

+4-4
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,16 @@
2020
</ItemGroup>
2121

2222
<Target Name="_EnsurePyEx86" Condition="!Exists('$(BuildPath32)py.exe')" BeforeTargets="PrepareForBuild">
23-
<MSBuild Projects="$(PySourcePath)PCBuild\pylauncher.vcxproj" Properties="Platform=Win32" />
23+
<MSBuild Projects="$(PySourcePath)PCbuild\pylauncher.vcxproj" Properties="Platform=Win32" />
2424
</Target>
2525
<Target Name="_EnsurePywEx86" Condition="!Exists('$(BuildPath32)pyw.exe')" BeforeTargets="PrepareForBuild">
26-
<MSBuild Projects="$(PySourcePath)PCBuild\pywlauncher.vcxproj" Properties="Platform=Win32" />
26+
<MSBuild Projects="$(PySourcePath)PCbuild\pywlauncher.vcxproj" Properties="Platform=Win32" />
2727
</Target>
2828
<Target Name="_EnsurePyShellExt86" Condition="!Exists('$(BuildPath32)pyshellext.dll')" BeforeTargets="PrepareForBuild">
29-
<MSBuild Projects="$(PySourcePath)PCBuild\pyshellext.vcxproj" Properties="Platform=Win32" />
29+
<MSBuild Projects="$(PySourcePath)PCbuild\pyshellext.vcxproj" Properties="Platform=Win32" />
3030
</Target>
3131
<Target Name="_EnsurePyShellExt64" Condition="!Exists('$(BuildPath64)pyshellext.dll')" BeforeTargets="PrepareForBuild">
32-
<MSBuild Projects="$(PySourcePath)PCBuild\pyshellext.vcxproj" Properties="Platform=x64" />
32+
<MSBuild Projects="$(PySourcePath)PCbuild\pyshellext.vcxproj" Properties="Platform=x64" />
3333
</Target>
3434

3535
<Import Project="..\msi.targets" />

Tools/msi/msi.props

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
</PropertyGroup>
1616

1717
<Import Project="wix.props" />
18-
<Import Project="..\..\PCBuild\tcltk.props" />
18+
<Import Project="..\..\PCbuild\tcltk.props" />
1919

2020
<PropertyGroup>
2121
<!--

Tools/msi/testrelease.bat

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
@echo off
33

44
set D=%~dp0
5-
set PCBUILD=%D%..\..\PCBuild\
5+
set PCBUILD=%D%..\..\PCbuild\
66

77
set TARGETDIR=%TEMP%
88
set TESTX86=

Tools/msi/uploadrelease.bat

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
@echo off
33

44
set D=%~dp0
5-
set PCBUILD=%D%..\..\PCBuild\
5+
set PCBUILD=%D%..\..\PCbuild\
66

77
set HOST=
88
set USER=

Tools/msi/wix.props

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
3-
<Import Project="..\..\PCBuild\python.props" />
3+
<Import Project="..\..\PCbuild\python.props" />
44

55
<PropertyGroup>
66
<WixInstallPath Condition="'$(WixInstallPath)' == '' and Exists('$(MSBuildThisFileDirectory)\Wix')">$(MSBuildThisFileDirectory)\Wix\</WixInstallPath>

Tools/nuget/build.bat

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
@echo off
22
setlocal
33
set D=%~dp0
4-
set PCBUILD=%D%..\..\PCBuild\
4+
set PCBUILD=%D%..\..\PCbuild\
55
if "%Py_OutDir%"=="" set Py_OutDir=%PCBUILD%
66

77
set BUILDX86=

0 commit comments

Comments
 (0)