Skip to content

Commit ff54dd9

Browse files
authored
gh-90989: Install Windows launcher per-user, and clarify some installer text (GH-97655)
1 parent 73942e4 commit ff54dd9

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
Made :ref:`launcher` install per-user by default (unless an all users
2+
install already exists), and clarify some text in the installer.

Tools/msi/bundle/Default.wxl

+6-6
Original file line numberDiff line numberDiff line change
@@ -79,15 +79,15 @@ Select Customize to review current options.</String>
7979
<String Id="Include_launcherRemove">Use Programs and Features to remove the 'py' launcher.</String>
8080
<String Id="Include_launcherUpgrade">Upgrades the global 'py' launcher from the previous version.</String>
8181

82-
<String Id="AssociateFilesLabel">Associate &amp;files with Python (requires the py launcher)</String>
82+
<String Id="AssociateFilesLabel">Associate &amp;files with Python (requires the 'py' launcher)</String>
8383
<String Id="ShortcutsLabel">Create shortcuts for installed applications</String>
8484
<String Id="PrependPathLabel">Add Python to &amp;environment variables</String>
85-
<String Id="ShortPrependPathLabel">Add &amp;Python [ShortVersion] to PATH</String>
85+
<String Id="ShortPrependPathLabel">Add &amp;python.exe to PATH</String>
8686
<String Id="AppendPathLabel">Append Python to &amp;environment variables</String>
87-
<String Id="ShortAppendPathLabel">Append &amp;Python [ShortVersion] to PATH</String>
88-
<String Id="InstallAllUsersLabel">Install for &amp;all users</String>
89-
<String Id="InstallLauncherAllUsersLabel">for &amp;all users (requires elevation)</String>
90-
<String Id="ShortInstallLauncherAllUsersLabel">Install &amp;launcher for all users (recommended)</String>
87+
<String Id="ShortAppendPathLabel">Append &amp;python.exe to PATH</String>
88+
<String Id="InstallAllUsersLabel">Install Python [ShortVersion] for &amp;all users</String>
89+
<String Id="InstallLauncherAllUsersLabel">for &amp;all users (requires admin privileges)</String>
90+
<String Id="ShortInstallLauncherAllUsersLabel">Use admin privi&amp;leges when installing py.exe</String>
9191
<String Id="PrecompileLabel">&amp;Precompile standard library</String>
9292
<String Id="Include_symbolsLabel">Download debugging &amp;symbols</String>
9393
<String Id="Include_debugLabel">Download debu&amp;g binaries (requires VS 2017 or later)</String>

Tools/msi/bundle/bundle.wxs

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828

2929
<Variable Name="InstallAllUsers" Value="0" bal:Overridable="yes" />
3030
<?if "$(var.PyTestExt)"="" ?>
31-
<Variable Name="InstallLauncherAllUsers" Value="1" bal:Overridable="yes" />
31+
<Variable Name="InstallLauncherAllUsers" Value="0" bal:Overridable="yes" />
3232
<?else ?>
3333
<Variable Name="InstallLauncherAllUsers" Value="0" />
3434
<?endif ?>

0 commit comments

Comments
 (0)