Skip to content

Don't define CTYPES_PASS_BY_REF_HACK on aarch64 or riscv64 #103438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andreas-schwab opened this issue Apr 11, 2023 · 2 comments
Open

Don't define CTYPES_PASS_BY_REF_HACK on aarch64 or riscv64 #103438

andreas-schwab opened this issue Apr 11, 2023 · 2 comments
Labels
topic-ctypes type-bug An unexpected behavior, bug, or error

Comments

@andreas-schwab
Copy link
Contributor

andreas-schwab commented Apr 11, 2023

There is no need to define CTYPES_PASS_BY_REF_HACK on aarch64 or riscv64. This was a bug in libffi that has since been been fixed, for riscv64 in commit 4b0c358 and for aarch64 in commit e409225.

Linked PRs

@FFY00
Copy link
Member

FFY00 commented Apr 11, 2023

The fix is only available on libfii 3.4.4, for riscv, and 3.4.3, for aarch, so it'd make sense to document this.

@ronaldoussoren
Copy link
Contributor

Unconditionally removing the workaround for aarch64 could break builds on macOS that use the system install of libffi, including the installers on our website. Therefore I'm -1 on unconditionally removing the workaround.

Is the need for using the workaround something that can be tested in the configure script?

Even then it would be preferable to continue using the workaround on macOS because we also target older macOS versions that likely will never see this bug fix in the system install of libffi. Using the system install of libffi is desirable due to code signing "tricks" in that build of libffi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-ctypes type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

5 participants