-
-
Notifications
You must be signed in to change notification settings - Fork 32k
Remove deprecated code.co_lnotab
#119664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
code.co_lnotab
code.co_lnotab
code.co_lnotab
code.co_lnotab
What is the reason for removing it?
For someone who uses it and will be required to change their code this is not minor. We don't always remove things just because we can, if they are not getting in anyone's way. I think this decision needs to be discussed. |
Oh it was actually scheduled for removal in Python 3.14 (deprecated in 3.12). Actually, it was scheduled for removal for 3.12 but since no DeprecationWarning was set in 3.10, it got delayed (see https://peps.python.org/pep-0626/#backwards-compatibility). EDIT 1: Also, in 3.10 and 3.12 it was said "will be removed" but for 3.13 it was marked "may be removed". Feel free to close the related PR if a discussion is needed (or maybe I should open one on discourse?). EDIT 2: If I were to motivate the reason, there are two points to adress:
Now, if you think that someone is using it and we would break it, I think they should likely update their code and use the new |
I don't see any need to remove this just yet. We will probably need to remove it at some point, in order to change the internal format of the position table, but we might as well leave until then. |
Then would you consider the rewording of the removal notice as presented in #120263? (so that we don't have confusion in the future) |
(Closing as |
Uh oh!
There was an error while loading. Please reload this page.
Feature or enhancement
Proposal:
This is an issue to track the removal of
code.co_lnotab
deprecated since 3.12 and scheduled for removal in 3.14.In #101865, it is marked "may be removed" but I think it should be removed. If not, we should harmonize the docs which sometimes state "will be removed" and sometimes say "may be removed" (also the corresponding tests are marked as "todo: remove in 3.14").
Has this already been discussed elsewhere?
No, so we can discuss here whether we should remove it now or not.
Links to previous discussion of this feature:
#101865
Linked PRs
co_lnotab
#119665codeobject.co_lnotab
#120263The text was updated successfully, but these errors were encountered: