Skip to content

venv API docs - symlinks default incorrect #76700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jaraco opened this issue Jan 8, 2018 · 4 comments
Closed

venv API docs - symlinks default incorrect #76700

jaraco opened this issue Jan 8, 2018 · 4 comments
Labels
stdlib Python modules in the Lib dir

Comments

@jaraco
Copy link
Member

jaraco commented Jan 8, 2018

BPO 32519
Nosy @vsajip, @jaraco
PRs
  • bpo-32519: Removed misleading sentence from EnvBuilder documentation. #7296
  • [3.6] bpo-32519: Removed misleading sentence from EnvBuilder documentation. (GH-7296) #7299
  • [3.7] bpo-32519: Removed misleading sentence from EnvBuilder documentation. (GH-7296) #7300
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2018-06-01.09:11:19.600>
    created_at = <Date 2018-01-08.14:58:36.548>
    labels = ['library']
    title = 'venv API docs - symlinks default incorrect'
    updated_at = <Date 2018-06-01.17:57:14.982>
    user = 'https://github.com/jaraco'

    bugs.python.org fields:

    activity = <Date 2018-06-01.17:57:14.982>
    actor = 'vinay.sajip'
    assignee = 'none'
    closed = True
    closed_date = <Date 2018-06-01.09:11:19.600>
    closer = 'vinay.sajip'
    components = ['Library (Lib)']
    creation = <Date 2018-01-08.14:58:36.548>
    creator = 'jaraco'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 32519
    keywords = ['patch']
    message_count = 4.0
    messages = ['309667', '318374', '318446', '318447']
    nosy_count = 2.0
    nosy_names = ['vinay.sajip', 'jaraco']
    pr_nums = ['7296', '7299', '7300']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue32519'
    versions = []

    @jaraco
    Copy link
    Member Author

    jaraco commented Jan 8, 2018

    In the API docs for EnvBuilder.symlinks, it states "Defaults to True on Linux and Unix systems, but False on Windows." But in fact, the implementation takes the value passed, which always defaults to False. It's only on the command-line that the default is inferred from the system. Presumably, the fix is to strike that sentence from the docs.

    @jaraco jaraco added the stdlib Python modules in the Lib dir label Jan 8, 2018
    @vsajip
    Copy link
    Member

    vsajip commented Jun 1, 2018

    New changeset c0d341d by Vinay Sajip in branch 'master':
    bpo-32519: Removed misleading sentence from EnvBuilder documentation. (GH-7296)
    c0d341d

    @vsajip vsajip closed this as completed Jun 1, 2018
    @vsajip
    Copy link
    Member

    vsajip commented Jun 1, 2018

    New changeset 1df877c by Vinay Sajip (Miss Islington (bot)) in branch '3.6':
    bpo-32519: Removed misleading sentence from EnvBuilder documentation. (GH-7296) (GH-7299)
    1df877c

    @vsajip
    Copy link
    Member

    vsajip commented Jun 1, 2018

    New changeset 283e12f by Vinay Sajip (Miss Islington (bot)) in branch '3.7':
    bpo-32519: Removed misleading sentence from EnvBuilder documentation. (GH-7296) (bpo-7300)
    283e12f

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants