From fb65c5fd6de2332c98a14d134d11fdb841509836 Mon Sep 17 00:00:00 2001 From: Radislav Chugunov Date: Fri, 19 May 2023 21:14:53 +0300 Subject: [PATCH 1/2] skip test_subprocess.ProcessTestCase.test_empty_env if ASAN is enabled --- Lib/test/test_subprocess.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py index 3880125807f235..6c3a2d5da8973c 100644 --- a/Lib/test/test_subprocess.py +++ b/Lib/test/test_subprocess.py @@ -1,6 +1,7 @@ import unittest from unittest import mock from test import support +from test.support import check_sanitizer from test.support import import_helper from test.support import os_helper from test.support import warnings_helper @@ -790,6 +791,8 @@ def test_env(self): @unittest.skipIf(sysconfig.get_config_var('Py_ENABLE_SHARED') == 1, 'The Python shared library cannot be loaded ' 'with an empty environment.') + @unittest.skipIf(check_sanitizer(address=True), + 'AddressSanitizer cannot be runned with empty env') def test_empty_env(self): """Verify that env={} is as empty as possible.""" From d8d36152a51a51bb990c36930e99f14f6c1707d9 Mon Sep 17 00:00:00 2001 From: "Gregory P. Smith" Date: Fri, 19 May 2023 11:59:30 -0700 Subject: [PATCH 2/2] reword skipIf message. --- Lib/test/test_subprocess.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py index 6c3a2d5da8973c..92f81eaafb1c93 100644 --- a/Lib/test/test_subprocess.py +++ b/Lib/test/test_subprocess.py @@ -792,7 +792,7 @@ def test_env(self): 'The Python shared library cannot be loaded ' 'with an empty environment.') @unittest.skipIf(check_sanitizer(address=True), - 'AddressSanitizer cannot be runned with empty env') + 'AddressSanitizer adds to the environment.') def test_empty_env(self): """Verify that env={} is as empty as possible."""