From 21d361eb3162262cc099c4ffdf64330033bc4f98 Mon Sep 17 00:00:00 2001 From: David Goncalves Date: Sat, 2 Apr 2022 19:40:00 -0700 Subject: [PATCH 1/2] bpo-18624: add alias for iso-8859-8-i and -e to iso_8859_8 --- Lib/encodings/aliases.py | 2 ++ Lib/test/test_codecs.py | 8 ++++++++ 2 files changed, 10 insertions(+) diff --git a/Lib/encodings/aliases.py b/Lib/encodings/aliases.py index d85afd6d5cf704..d8bee4337db4ce 100644 --- a/Lib/encodings/aliases.py +++ b/Lib/encodings/aliases.py @@ -398,6 +398,8 @@ 'iso_8859_8' : 'iso8859_8', 'iso_8859_8_1988' : 'iso8859_8', 'iso_ir_138' : 'iso8859_8', + 'iso_8859_8_i' : 'iso8859_8', + 'iso_8859_8_e' : 'iso8859_8', # iso8859_9 codec 'csisolatin5' : 'iso8859_9', diff --git a/Lib/test/test_codecs.py b/Lib/test/test_codecs.py index 5853e088197153..b91ad98bcc9163 100644 --- a/Lib/test/test_codecs.py +++ b/Lib/test/test_codecs.py @@ -2,6 +2,7 @@ import contextlib import io import locale +import os import sys import unittest import encodings @@ -2836,6 +2837,13 @@ def test_aliases(self): info = codecs.lookup(alias) self.assertEqual(info.name, expected_name) + def test_alias_modules_exist(self): + encodings_dir = os.path.dirname(encodings.__file__) + for value in encodings.aliases.aliases.values(): + codec_file = os.path.join(encodings_dir, value + ".py") + self.assertTrue(os.path.isfile(codec_file), + "Codec file not found: " + codec_file) + def test_quopri_stateless(self): # Should encode with quotetabs=True encoded = codecs.encode(b"space tab\teol \n", "quopri-codec") From 60ff3e1c56ce074965147d38a09e94fb2d8a67c0 Mon Sep 17 00:00:00 2001 From: Oleg Iarygin Date: Mon, 13 Feb 2023 21:56:46 +0400 Subject: [PATCH 2/2] Add a news entry --- .../next/Library/2023-02-13-21-56-38.gh-issue-62824.CBZzX3.rst | 1 + 1 file changed, 1 insertion(+) create mode 100644 Misc/NEWS.d/next/Library/2023-02-13-21-56-38.gh-issue-62824.CBZzX3.rst diff --git a/Misc/NEWS.d/next/Library/2023-02-13-21-56-38.gh-issue-62824.CBZzX3.rst b/Misc/NEWS.d/next/Library/2023-02-13-21-56-38.gh-issue-62824.CBZzX3.rst new file mode 100644 index 00000000000000..1fe4e47c9ec213 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2023-02-13-21-56-38.gh-issue-62824.CBZzX3.rst @@ -0,0 +1 @@ +Fix aliases for ``iso8859_8`` encoding. Patch by Dave Goncalves.