From 5255da278784a7199cdf3d98f1d94ec2b7bb9c9b Mon Sep 17 00:00:00 2001 From: Brett Cannon Date: Tue, 12 Apr 2022 19:50:15 -0700 Subject: [PATCH 1/2] Deprecate msilib --- Lib/msilib/__init__.py | 3 +++ Lib/test/test_msilib.py | 5 ++++- .../Library/2022-04-12-19-42-20.gh-issue-91217.b9_Rz9.rst | 1 + 3 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 Misc/NEWS.d/next/Library/2022-04-12-19-42-20.gh-issue-91217.b9_Rz9.rst diff --git a/Lib/msilib/__init__.py b/Lib/msilib/__init__.py index 0e85aa28967eaf..565bf631abd4ed 100644 --- a/Lib/msilib/__init__.py +++ b/Lib/msilib/__init__.py @@ -6,6 +6,9 @@ import re import string import sys +import warnings + +warnings._deprecated(__name__, remove=(3, 13)) AMD64 = "AMD64" in sys.version # Keep msilib.Win64 around to preserve backwards compatibility. diff --git a/Lib/test/test_msilib.py b/Lib/test/test_msilib.py index e29cd4a84c5469..db16f62a4c121e 100644 --- a/Lib/test/test_msilib.py +++ b/Lib/test/test_msilib.py @@ -3,7 +3,10 @@ import unittest from test.support.import_helper import import_module from test.support.os_helper import TESTFN, unlink -msilib = import_module('msilib') +import warnings +with warnings.catch_warnings(): + warnings.simplefilter("ignore", DeprecationWarning) + msilib = import_module('msilib') import msilib.schema diff --git a/Misc/NEWS.d/next/Library/2022-04-12-19-42-20.gh-issue-91217.b9_Rz9.rst b/Misc/NEWS.d/next/Library/2022-04-12-19-42-20.gh-issue-91217.b9_Rz9.rst new file mode 100644 index 00000000000000..ee1fc22deaef07 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2022-04-12-19-42-20.gh-issue-91217.b9_Rz9.rst @@ -0,0 +1 @@ +Deprecate msilib. From 1f9fa98ebff66acbcf843042eb2749fa129f313c Mon Sep 17 00:00:00 2001 From: Brett Cannon Date: Wed, 13 Apr 2022 18:03:23 -0700 Subject: [PATCH 2/2] Add a What's New entry --- Doc/whatsnew/3.11.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Doc/whatsnew/3.11.rst b/Doc/whatsnew/3.11.rst index 894ec8a9d0d928..f8e86f6ba349b2 100644 --- a/Doc/whatsnew/3.11.rst +++ b/Doc/whatsnew/3.11.rst @@ -857,6 +857,7 @@ Deprecated * :mod:`chunk` * :mod:`crypt` * :mod:`imghdr` + * :mod:`msilib` (Contributed by Brett Cannon in :issue:`47061`.)