Merge branch 'skip_zipp_not_a_file' into 'master'

Skip zipp.Path when it is not a file

See merge request python-devs/importlib_metadata!75

Author: jaraco

importlib_metadata/__init__.py

@@ -1,6 +1,7 @@
 from __future__ import unicode_literals, absolute_import
 
 import io
+import os
 import re
 import abc
 import csv
@@ -22,6 +23,7 @@
     NotADirectoryError,
     PermissionError,
     pathlib,
+    PYPY_OPEN_BUG,
     ModuleNotFoundError,
     MetaPathFinder,
     email_message_from_string,
@@ -366,8 +368,9 @@ def _search_paths(cls, pattern, paths):
 
     @staticmethod
     def _switch_path(path):
-        with suppress(Exception):
-            return zipp.Path(path)
+        if not PYPY_OPEN_BUG or os.path.isfile(path):  # pragma: no branch
+            with suppress(Exception):
+                return zipp.Path(path)
         return pathlib.Path(path)
 
     @classmethod

importlib_metadata/_compat.py

@@ -86,3 +86,6 @@ def py2_message_from_string(text):  # nocoverpy3
     if sys.version_info < (3,) else
     email.message_from_string
     )
+
+# https://bitbucket.org/pypy/pypy/issues/3021/ioopen-directory-leaks-a-file-descriptor
+PYPY_OPEN_BUG = getattr(sys, 'pypy_version_info', (9, 9, 9))[:3] <= (7, 1, 1)