Skip to content

Commit a633a72

Browse files
hauntsaninjaJelleZijlstra
authored andcommitted
Revert sum literal integer change (#13961)
This is allegedly causing large performance problems, see 13821 typeshed/8231 had zero hits on mypy_primer, so it's not the worst thing to undo. Patching this in typeshed also feels weird, since there's a more general soundness issue. If a typevar has a bound or constraint, we might not want to solve it to a Literal. If we can confirm the performance regression or fix the unsoundness within mypy, I might pursue upstreaming this in typeshed. (Reminder: add this to the sync_typeshed script once merged)
1 parent 250e6fd commit a633a72

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

mypy/typeshed/stdlib/builtins.pyi

+2-2
Original file line numberDiff line numberDiff line change
@@ -1638,11 +1638,11 @@ _SupportsSumNoDefaultT = TypeVar("_SupportsSumNoDefaultT", bound=_SupportsSumWit
16381638
# Instead, we special-case the most common examples of this: bool and literal integers.
16391639
if sys.version_info >= (3, 8):
16401640
@overload
1641-
def sum(__iterable: Iterable[bool | _LiteralInteger], start: int = 0) -> int: ... # type: ignore[misc]
1641+
def sum(__iterable: Iterable[bool], start: int = 0) -> int: ... # type: ignore[misc]
16421642

16431643
else:
16441644
@overload
1645-
def sum(__iterable: Iterable[bool | _LiteralInteger], __start: int = 0) -> int: ... # type: ignore[misc]
1645+
def sum(__iterable: Iterable[bool], __start: int = 0) -> int: ... # type: ignore[misc]
16461646

16471647
@overload
16481648
def sum(__iterable: Iterable[_SupportsSumNoDefaultT]) -> _SupportsSumNoDefaultT | Literal[0]: ...

0 commit comments

Comments
 (0)