Skip to content

Commit b8dd40e

Browse files
authored
TestItem: convert to dataclass, remove class vars (#15286)
`TestItem` has instance attributes, so it doesn't need the class vars.
1 parent 9270819 commit b8dd40e

File tree

1 file changed

+5
-13
lines changed

1 file changed

+5
-13
lines changed

mypy/test/data.py

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import sys
1111
import tempfile
1212
from abc import abstractmethod
13+
from dataclasses import dataclass
1314
from typing import Any, Iterator, NamedTuple, Pattern, Union
1415
from typing_extensions import Final, TypeAlias as _TypeAlias
1516

@@ -414,6 +415,7 @@ def module_from_path(path: str) -> str:
414415
return module
415416

416417

418+
@dataclass
417419
class TestItem:
418420
"""Parsed test caseitem.
419421
@@ -422,20 +424,10 @@ class TestItem:
422424
.. data ..
423425
"""
424426

425-
id = ""
426-
arg: str | None = ""
427-
428-
# Text data, array of 8-bit strings
427+
id: str
428+
arg: str | None
429429
data: list[str]
430-
431-
file = ""
432-
line = 0 # Line number in file
433-
434-
def __init__(self, id: str, arg: str | None, data: list[str], line: int) -> None:
435-
self.id = id
436-
self.arg = arg
437-
self.data = data
438-
self.line = line
430+
line: int
439431

440432

441433
def parse_test_data(raw_data: str, name: str) -> list[TestItem]:

0 commit comments

Comments
 (0)