Skip to content

Incorrectly highlighted paragraph in dark theme #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Eclips4 opened this issue Aug 24, 2023 · 5 comments · Fixed by #150
Closed

Incorrectly highlighted paragraph in dark theme #149

Eclips4 opened this issue Aug 24, 2023 · 5 comments · Fixed by #150
Labels
bug

Comments

@Eclips4
Copy link
Member

Eclips4 commented Aug 24, 2023

Using dark theme this paragraph looks unreadable:

image
@Eclips4
Copy link
Member Author

Eclips4 commented Aug 24, 2023 •
edited
Loading

However, if I choose doc version 3.12 or 3.11, paragraph seems fine.

@AA-Turner
Copy link
Member

Should be reported to https://github.com/python/python-docs-theme (I can't transfer the issue).

A

@AA-Turner AA-Turner closed this as not planned Won't fix, can't repro, duplicate, stale Aug 24, 2023
@JelleZijlstra JelleZijlstra reopened this Aug 24, 2023
@JelleZijlstra JelleZijlstra transferred this issue from python/cpython Aug 24, 2023
@AA-Turner
Copy link
Member

We exclude 2023.7 (python/cpython#107666) due to #144. #146 was merged to revert, but there hasn't been a new release yet (#148).

A

@hugovk
Copy link
Member

hugovk commented Aug 24, 2023

Looks this is a fresh bug not covered by #138, I'll make a PR and then let's do a release.

@hugovk hugovk mentioned this issue Aug 24, 2023
Merged
@hugovk
Copy link
Member

hugovk commented Aug 24, 2023

Please see PR #150.

@hugovk hugovk added the bug label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dark mode: Also give aside.topic a dark background hugovk/python-docs-theme
4 participants
@JelleZijlstra @hugovk @AA-Turner @Eclips4