Skip to content

Commit 1f76489

Browse files
unittest: cannot use bytes regexes (#9107)
``` >>> from unittest.case import TestCase >>> c = TestCase() >>> with c.assertRaisesRegex(Exception, b"x"): 1/0 ... ZeroDivisionError: division by zero During handling of the above exception, another exception occurred: Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/unittest/case.py", line 274, in __exit__ if not expected_regex.search(str(exc_value)): ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ TypeError: cannot use a bytes pattern on a string-like object ```
1 parent 3d64286 commit 1f76489

File tree

1 file changed

+4
-12
lines changed

1 file changed

+4
-12
lines changed

stdlib/unittest/case.pyi

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -157,18 +157,14 @@ class TestCase:
157157
def assertRaisesRegex( # type: ignore[misc]
158158
self,
159159
expected_exception: type[BaseException] | tuple[type[BaseException], ...],
160-
expected_regex: str | bytes | Pattern[str] | Pattern[bytes],
160+
expected_regex: str | Pattern[str],
161161
callable: Callable[..., Any],
162162
*args: Any,
163163
**kwargs: Any,
164164
) -> None: ...
165165
@overload
166166
def assertRaisesRegex(
167-
self,
168-
expected_exception: type[_E] | tuple[type[_E], ...],
169-
expected_regex: str | bytes | Pattern[str] | Pattern[bytes],
170-
*,
171-
msg: Any = ...,
167+
self, expected_exception: type[_E] | tuple[type[_E], ...], expected_regex: str | Pattern[str], *, msg: Any = ...
172168
) -> _AssertRaisesContext[_E]: ...
173169
@overload
174170
def assertWarns( # type: ignore[misc]
@@ -186,18 +182,14 @@ class TestCase:
186182
def assertWarnsRegex( # type: ignore[misc]
187183
self,
188184
expected_warning: type[Warning] | tuple[type[Warning], ...],
189-
expected_regex: str | bytes | Pattern[str] | Pattern[bytes],
185+
expected_regex: str | Pattern[str],
190186
callable: Callable[_P, Any],
191187
*args: _P.args,
192188
**kwargs: _P.kwargs,
193189
) -> None: ...
194190
@overload
195191
def assertWarnsRegex(
196-
self,
197-
expected_warning: type[Warning] | tuple[type[Warning], ...],
198-
expected_regex: str | bytes | Pattern[str] | Pattern[bytes],
199-
*,
200-
msg: Any = ...,
192+
self, expected_warning: type[Warning] | tuple[type[Warning], ...], expected_regex: str | Pattern[str], *, msg: Any = ...
201193
) -> _AssertWarnsContext: ...
202194
def assertLogs(
203195
self, logger: str | logging.Logger | None = ..., level: int | str | None = ...

0 commit comments

Comments
 (0)