Skip to content

Commit 21c9ac5

Browse files
authored
Enable running stubtest on more of types-pika (#9826)
Make aliases for non-imported dependency private
1 parent 0cd5bf0 commit 21c9ac5

File tree

3 files changed

+7
-9
lines changed

3 files changed

+7
-9
lines changed

stubs/pika/@tests/stubtest_allowlist.txt

-5
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,6 @@
22
pika.compat.StringIO.seek
33
pika.compat.StringIO.truncate
44

5-
# Requires external libraries to be installed.
6-
pika\.adapters\.gevent_connection.*
7-
pika\.adapters\.tornado_connection.*
8-
pika\.adapters\.twisted_connection.*
9-
105
# Stubtest doesn't understand that a property alias is also read-only.
116
pika.BlockingConnection.basic_nack
127
pika.BlockingConnection.consumer_cancel_notify

stubs/pika/METADATA.toml

+3
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,6 @@ extra_description = """\
44
The `types-pika` package contains alternate, more complete type stubs, that \
55
are maintained outside of typeshed.\
66
"""
7+
8+
[tool.stubtest]
9+
stubtest_requirements = ["gevent", "tornado", "twisted"]

stubs/pika/pika/adapters/twisted_connection.pyi

+4-4
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@ from typing_extensions import TypeAlias
55
import pika.connection
66
from pika.adapters.utils import nbio_interface
77

8-
DeferredQueue: TypeAlias = Any # TODO: twisted.internet.defer.DeferredQueue
9-
Protocol: TypeAlias = Any # TODO: twisted.internet.protocol.Protocol
8+
_DeferredQueue: TypeAlias = Any # TODO: twisted.internet.defer.DeferredQueue
9+
_Protocol: TypeAlias = Any # TODO: twisted.internet.protocol.Protocol
1010

1111
LOGGER: Incomplete
1212

13-
class ClosableDeferredQueue(DeferredQueue):
13+
class ClosableDeferredQueue(_DeferredQueue):
1414
closed: Incomplete
1515
def __init__(self, size: Incomplete | None = ..., backlog: Incomplete | None = ...) -> None: ...
1616
def put(self, obj): ...
@@ -107,7 +107,7 @@ class _TwistedConnectionAdapter(pika.connection.Connection):
107107
def connection_lost(self, error) -> None: ...
108108
def data_received(self, data) -> None: ...
109109

110-
class TwistedProtocolConnection(Protocol):
110+
class TwistedProtocolConnection(_Protocol):
111111
ready: Incomplete
112112
closed: Incomplete
113113
def __init__(self, parameters: Incomplete | None = ..., custom_reactor: Incomplete | None = ...) -> None: ...

0 commit comments

Comments
 (0)