Skip to content

Commit 9ba6f8b

Browse files
committed
Try Jake's suggestion using GITHUB_PATH
1 parent 59deecb commit 9ba6f8b

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

.github/workflows/tests.yml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -158,10 +158,10 @@ jobs:
158158
echo "Installing packages: $DEPENDENCIES"
159159
pip install $DEPENDENCIES
160160
fi
161+
- name: Activate the isolated venv for the rest of the job
162+
run: echo "$PWD/.venv/bin" >> $GITHUB_PATH
161163
- name: List 3rd-party stub dependencies installed
162-
run: |
163-
source .venv/bin/activate
164-
pip freeze --all
164+
run: pip freeze --all
165165
- name: Get pyright version
166166
uses: SebRollen/[email protected]
167167
id: pyright_version
@@ -175,15 +175,13 @@ jobs:
175175
python-platform: ${{ matrix.python-platform }}
176176
python-version: ${{ matrix.python-version }}
177177
no-comments: ${{ matrix.python-version != '3.10' || matrix.python-platform != 'Linux' }} # Having each job create the same comment is too noisy.
178-
extra-args: "--pythonpath=.venv/bin/python"
179178
- name: Run pyright with stricter settings on some of the stubs
180179
uses: jakebailey/pyright-action@v1
181180
with:
182181
version: ${{ steps.pyright_version.outputs.value }}
183182
python-platform: ${{ matrix.python-platform }}
184183
python-version: ${{ matrix.python-version }}
185184
no-comments: ${{ matrix.python-version != '3.10' || matrix.python-platform != 'Linux' }} # Having each job create the same comment is too noisy.
186-
extra-args: "--pythonpath=.venv/bin/python"
187185
project: ./pyrightconfig.stricter.json
188186
- name: Run pyright on the test cases
189187
uses: jakebailey/pyright-action@v1
@@ -192,7 +190,6 @@ jobs:
192190
python-platform: ${{ matrix.python-platform }}
193191
python-version: ${{ matrix.python-version }}
194192
no-comments: ${{ matrix.python-version != '3.10' || matrix.python-platform != 'Linux' }} # Having each job create the same comment is too noisy.
195-
extra-args: "--pythonpath=.venv/bin/python"
196193
project: ./pyrightconfig.testcases.json
197194

198195
stub-uploader:

0 commit comments

Comments
 (0)