Skip to content

Commit ad8019d

Browse files
committed
Merge pull request #78 from rmcgibbo/minmax
Improvements to builtins min/max
2 parents 2161307 + 9933080 commit ad8019d

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

stdlib/2.7/__builtin__.pyi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -677,12 +677,12 @@ def map(func: Callable[[_T1, _T2], _S],
677677
iter1: Iterable[_T1],
678678
iter2: Iterable[_T2]) -> List[_S]: ... # TODO more than two iterables
679679
@overload
680-
def max(arg1: _T, arg2: _T, *args: _T) -> _T: ...
680+
def max(arg1: _T, arg2: _T, *args: _T, key: Callable[[_T], Any] = None) -> _T: ...
681681
@overload
682682
def max(iterable: Iterable[_T], key: Callable[[_T], Any] = None) -> _T: ...
683683
# TODO memoryview
684684
@overload
685-
def min(arg1: _T, arg2: _T, *args: _T) -> _T: ...
685+
def min(arg1: _T, arg2: _T, *args: _T, key: Callable[[_T], Any] = None) -> _T: ...
686686
@overload
687687
def min(iterable: Iterable[_T], key: Callable[[_T], Any] = None) -> _T: ...
688688
@overload

stdlib/3/builtins.pyi

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -658,14 +658,14 @@ def map(func: Callable[[_T1], _S], iter1: Iterable[_T1]) -> Iterator[_S]: ...
658658
def map(func: Callable[[_T1, _T2], _S], iter1: Iterable[_T1],
659659
iter2: Iterable[_T2]) -> Iterator[_S]: ... # TODO more than two iterables
660660
@overload
661-
def max(arg1: _T, arg2: _T, *args: _T) -> _T: ...
661+
def max(arg1: _T, arg2: _T, *args: _T, key: Callable[[_T], Any] = None) -> _T: ...
662662
@overload
663-
def max(iterable: Iterable[_T], key: Callable[[_T], Any] = None) -> _T: ...
663+
def max(iterable: Iterable[_T], key: Callable[[_T], Any] = None, default:_T = None) -> _T: ...
664664
# TODO memoryview
665665
@overload
666-
def min(arg1: _T, arg2: _T, *args: _T) -> _T: ...
666+
def min(arg1: _T, arg2: _T, *args: _T, key: Callable[[_T], Any] = None) -> _T: ...
667667
@overload
668-
def min(iterable: Iterable[_T], key: Callable[[_T], Any] = None) -> _T: ...
668+
def min(iterable: Iterable[_T], key: Callable[[_T], Any] = None, default:_T = None) -> _T: ...
669669
@overload
670670
def next(i: Iterator[_T]) -> _T: ...
671671
@overload

0 commit comments

Comments
 (0)