stubtest_stdlib: fail if there are unused allowlist entries (#6424)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: Akuli

.github/workflows/stubtest-unused-allowlist.yml

@@ -33,7 +33,7 @@ jobs:
       - name: Install dependencies
         run: pip install $(grep tomli== requirements-tests-py3.txt) $(grep mypy== requirements-tests-py3.txt)
       - name: Run stubtest
-        run: python tests/stubtest_stdlib.py --ignore-unused-allowlist
+        run: python tests/stubtest_stdlib.py
 
   stubtest-third-party:
     name: Check third party stubs with stubtest

.github/workflows/stubtest.yml

@@ -109,7 +109,7 @@ jobs:
       - name: Install dependencies
         run: pip install $(grep tomli== requirements-tests-py3.txt) $(grep mypy== requirements-tests-py3.txt)
       - name: Run stubtest
-        run: python tests/stubtest_stdlib.py --ignore-unused-allowlist
+        run: python tests/stubtest_stdlib.py
 
   stubtest-third-party:
     name: Check third party stubs with stubtest

.github/workflows/tests.yml

@@ -124,9 +124,6 @@ tkinter.EventType.__new__
 _markupbase.ParserBase.error
 asyncio.proactor_events._ProactorReadPipeTransport.__init__
 distutils.command.bdist_wininst
-logging.Formatter.__init__
-logging.LoggerAdapter.__init__
-logging.PercentStyle.__init__
 py_compile.main
 pyclbr.Class.__init__
 pyclbr.Function.__init__

tests/stubtest_allowlists/py310.txt

@@ -57,7 +57,8 @@ def run_stubtest(typeshed_dir: Path) -> int:
             "\nCommand run was: {}\n".format(" ".join(cmd)),
             file=sys.stderr,
         )
-        print("stubtest failed", file=sys.stderr)
+        print("\n\n", file=sys.stderr)
+        print(f'To fix "unused allowlist" errors, remove the corresponding entries from {allowlist_dir}', file=sys.stderr)
         return e.returncode
     else:
         print("stubtest succeeded", file=sys.stderr)