Apply suggestions from code review

Co-authored-by: Jelle Zijlstra <[email protected]>

Author: kasium

stubs/python-crontab/cronlog.pyi

@@ -21,7 +21,7 @@ class LogReader:
 
 class CronLog(LogReader):
     user: str | None
-    def __init__(self, filename: str = ..., user: str | None = ...) -> None: ...
+    def __init__(self, filename: StrOrBytesPath = ..., user: str | None = ...) -> None: ...
     def for_program(self, command: str) -> ProgramLog: ...
     def __iter__(self) -> dict[str, str | None]: ...  # type: ignore[override]
 

stubs/python-crontab/crontab.pyi

@@ -11,7 +11,7 @@ ITEMREX: re.Pattern[str]
 SPECREX: re.Pattern[str]
 DEVNULL: str
 WEEK_ENUM: list[str]
-MONTH_ENUM: list[str]
+MONTH_ENUM: list[str | None]
 SPECIALS: dict[str, str]
 SPECIAL_IGNORE: list[str]
 S_INFO: list[dict[str, Any]]
@@ -27,20 +27,20 @@ current_user: Callable[[], str | None]
 unicode = str
 basestring = str
 
-def open_pipe(cmd: Incomplete, *args: Incomplete, **flags: Incomplete) -> Incomplete: ...
+def open_pipe(cmd: str, *args: str, **flags) -> subprocess.Popen: ...
 
 class CronTab:
     lines: Incomplete
     crons: Incomplete
     filen: Incomplete
     cron_command: Incomplete
     env: Incomplete
-    root: Incomplete
+    root: bool
     intab: Incomplete
     def __init__(
         self, user: str | None = ..., tab: Incomplete | None = ..., tabfile: Incomplete | None = ..., log: Incomplete | None = ...
     ) -> None: ...
-    def __enter__(self) -> Incomplete: ...
+    def __enter__(self: Self) -> Self: ...
     def __exit__(
         self, exc_type: type[BaseException] | None, exc_val: BaseException | None, exc_tb: TracebackType | None
     ) -> None: ...
@@ -50,26 +50,25 @@ class CronTab:
     def user(self) -> str | None: ...
     @property
     def user_opt(self) -> Incomplete: ...
-    def __setattr__(self, name: str, value: Any) -> None: ...
     def read(self, filename: Incomplete | None = ...) -> None: ...
     def append(self, item: Incomplete, line: str = ..., read: bool = ...) -> None: ...
     def write(self, filename: Incomplete | None = ..., user: Incomplete | None = ..., errors: bool = ...) -> None: ...
     def write_to_user(self, user: bool = ...) -> Incomplete: ...
-    def run_pending(self, **kwargs: Any) -> Generator[Incomplete, None, None]: ...
-    def run_scheduler(self, timeout: int = ..., **kwargs: Any) -> Generator[Incomplete, None, None]: ...
+    def run_pending(self, **kwargs) -> Generator[Incomplete, None, None]: ...
+    def run_scheduler(self, timeout: int = ..., **kwargs) -> Generator[Incomplete, None, None]: ...
     def render(self, errors: bool = ..., specials: bool = ...) -> Incomplete: ...
     def new(
         self, command: str = ..., comment: str = ..., user: Incomplete | None = ..., pre_comment: bool = ...
-    ) -> Incomplete: ...
-    def find_command(self, command: Incomplete) -> Generator[Incomplete, None, None]: ...
-    def find_comment(self, comment: Incomplete) -> Generator[Incomplete, None, None]: ...
-    def find_time(self, *args: Any) -> Generator[Incomplete, None, None]: ...
+    ) -> CronItem: ...
+    def find_command(self, command) -> Generator[Incomplete, None, None]: ...
+    def find_comment(self, comment) -> Generator[Incomplete, None, None]: ...
+    def find_time(self, *args) -> Generator[Incomplete, None, None]: ...
     @property
     def commands(self) -> Generator[Incomplete, None, None]: ...
     @property
     def comments(self) -> Generator[Incomplete, None, None]: ...
-    def remove_all(self, *args: Any, **kwargs: Any) -> Incomplete: ...
-    def remove(self, *items: Incomplete) -> Incomplete: ...
+    def remove_all(self, *args, **kwargs): ...
+    def remove(self, *items): ...
     def __iter__(self) -> Incomplete: ...
     def __getitem__(self, i: Incomplete) -> Incomplete: ...
     def __unicode__(self) -> Incomplete: ...
@@ -95,15 +94,15 @@ class CronItem:
     def __hash__(self) -> int: ...
     def __eq__(self, other: object) -> bool: ...
     @classmethod
-    def from_line(cls, line: Incomplete, user: Incomplete | None = ..., cron: Incomplete | None = ...) -> Incomplete: ...
+    def from_line(cls: type[Self], line: str, user: Incomplete | None = ..., cron: Incomplete | None = ...) -> Self: ...
     def delete(self) -> None: ...
-    def set_command(self, cmd: Incomplete, parse_stdin: bool = ...) -> None: ...
-    def set_comment(self, cmt: Incomplete, pre_comment: bool = ...) -> None: ...
+    def set_command(self, cmd: str, parse_stdin: bool = ...) -> None: ...
+    def set_comment(self, cmt: str, pre_comment: bool = ...) -> None: ...
     def parse(self, line: Incomplete) -> None: ...
-    def enable(self, enabled: bool = ...) -> Incomplete: ...
-    def is_enabled(self) -> Incomplete: ...
-    def is_valid(self) -> Incomplete: ...
-    def render(self, specials: bool = ...) -> Incomplete: ...
+    def enable(self, enabled: bool = ...) -> bool: ...
+    def is_enabled(self) -> bool: ...
+    def is_valid(self) -> bool: ...
+    def render(self, specials: bool = ...) -> str: ...
     def every_reboot(self) -> Incomplete: ...
     def every(self, unit: int = ...) -> Incomplete: ...
     def setall(self, *args: Any) -> Incomplete: ...
@@ -146,7 +145,7 @@ class Every:
     slices: Incomplete
     unit: Incomplete
     def __init__(self, item: Incomplete, units: Incomplete) -> None: ...
-    def set_attr(self, target: Incomplete) -> Incomplete: ...
+    def set_attr(self, target: int) -> Callable[[], None]: ...
     def year(self) -> None: ...
 
 class CronSlices(list[CronSlice]):
@@ -156,8 +155,8 @@ class CronSlices(list[CronSlice]):
     @classmethod
     def is_valid(cls, *args: Any) -> Incomplete: ...
     def setall(self, *slices: Incomplete) -> None: ...
-    def clean_render(self) -> Incomplete: ...
-    def render(self, specials: bool = ...) -> Incomplete: ...
+    def clean_render(self) -> str: ...
+    def render(self, specials: bool = ...) -> str: ...
     def clear(self) -> None: ...
     def frequency(self, year: Incomplete | None = ...) -> Incomplete: ...
     def frequency_per_year(self, year: Incomplete | None = ...) -> Incomplete: ...