Improve how we run pyright in CI (#10258)

Avoid using the deprecated `--venv-path` command-line argument

Author: AlexWaygood

.github/workflows/tests.yml

@@ -158,10 +158,10 @@ jobs:
             echo "Installing packages: $DEPENDENCIES"
             pip install $DEPENDENCIES
           fi
+      - name: Activate the isolated venv for the rest of the job
+        run: echo "$PWD/.venv/bin" >> $GITHUB_PATH
       - name: List 3rd-party stub dependencies installed
-        run: |
-          source .venv/bin/activate
-          pip freeze --all
+        run: pip freeze --all
       - name: Get pyright version
         uses: SebRollen/[email protected]
         id: pyright_version
@@ -175,15 +175,13 @@ jobs:
           python-platform: ${{ matrix.python-platform }}
           python-version: ${{ matrix.python-version }}
           no-comments: ${{ matrix.python-version != '3.11' || matrix.python-platform != 'Linux' }} # Having each job create the same comment is too noisy.
-          venv-path: .
       - name: Run pyright with stricter settings on some of the stubs
         uses: jakebailey/pyright-action@v1
         with:
           version: ${{ steps.pyright_version.outputs.value }}
           python-platform: ${{ matrix.python-platform }}
           python-version: ${{ matrix.python-version }}
           no-comments: ${{ matrix.python-version != '3.11' || matrix.python-platform != 'Linux' }} # Having each job create the same comment is too noisy.
-          venv-path: .
           project: ./pyrightconfig.stricter.json
       - name: Run pyright on the test cases
         uses: jakebailey/pyright-action@v1
@@ -192,7 +190,6 @@ jobs:
           python-platform: ${{ matrix.python-platform }}
           python-version: ${{ matrix.python-version }}
           no-comments: ${{ matrix.python-version != '3.11' || matrix.python-platform != 'Linux' }} # Having each job create the same comment is too noisy.
-          venv-path: .
           project: ./pyrightconfig.testcases.json
 
   stub-uploader:

pyrightconfig.json

@@ -1,7 +1,6 @@
 {
     "$schema": "https://github.com/raw/microsoft/pyright/main/packages/vscode-pyright/schemas/pyrightconfig.schema.json",
     "typeshedPath": ".",
-    "venv": ".venv",
     "include": [
         "stdlib",
         "stubs",

pyrightconfig.stricter.json

@@ -1,7 +1,6 @@
 {
     "$schema": "https://github.com/raw/microsoft/pyright/main/packages/vscode-pyright/schemas/pyrightconfig.schema.json",
     "typeshedPath": ".",
-    "venv": ".venv",
     "include": [
         "stdlib",
         "stubs",

pyrightconfig.testcases.json

@@ -1,7 +1,6 @@
 {
     "$schema": "https://github.com/raw/microsoft/pyright/main/packages/vscode-pyright/schemas/pyrightconfig.schema.json",
     "typeshedPath": ".",
-    "venv": ".venv",
     "include": [
         "test_cases",
         "stubs/**/@tests/test_cases"