-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Supporting Python 3.9 #3954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Sounds good. One problem is that Travis CI often lags a bit behind on new Python versions. I think we can already include Python 3.9 changes if someone submits them (and I think we already have a few), but for a concentrated effort I would wait for beta 1. Otherwise it's easy to miss something or change something that is later changed again. If we enable 3.9 in CI, we should make the 3.9 checks not fail CI, until the beta is released and available in CI. Otherwise we risk having builds fail for changes not related to the PR. That said, I'm +1 for enabling 3.9 in CI in a non-required way rather sooner than later. |
With the new windows Travis builds:
|
Python 3.9 got kicked in and out of CI a little bit. #4494 contains what we'd need to add Python 3.9 stubtest to Github Actions (including for Windows). However, in the meantime, a couple more errors have cropped up. Note, because we only check positional-only args on the latest Python version (#3693), a number of the Python 3.9 only complaints are just about positional-only args. |
I think overall the state here is good enough that we can close this issue.
|
Uh oh!
There was an error while loading. Please reload this page.
It looks like we're still a couple weeks away from beta, so maybe this is a little early, but thought I'd make a list of things we could do and we can start chipping away at it:
We can use https://gist.github.com/hauntsaninja/6870c77b502c0d19e33c831adac976ac as a starting point. Note if you're looking to regenerate this you'll need to use stubtest from mypy master.
Note that this might not be a complete list of changes. Two relatively major things stubtest won't catch are a) changes to argument types if their names haven't changed and they don't have default values that relate to the change, b) changes to return types.
Grepping for 3.9 in cpython/Doc is also relatively efficient for documented changes.
We should add a stubtest test for py39. As per How much do we care about positional-only args? #3693 we should switch checking positional-only args in py38 to checking them in py39. Make whitelist changes as necessary.
At some point, probably only after release, we can bump the default Python version we use for the rest of CI.
The text was updated successfully, but these errors were encountered: