From 8801f5e2602a2aed03965ae1c7fb17042aee6b05 Mon Sep 17 00:00:00 2001 From: Tim Van Baak Date: Wed, 19 Mar 2025 16:19:06 -0700 Subject: [PATCH] Fix incorrect default value for callback Upstream uses a default value of False when popping "callback" off of the kwargs dict. The type stubs should show callback as defaulting to False. See: https://github.com/miguelgrinberg/Flask-SocketIO/blob/3dbc92facf99d6bf1e7e354890c6113657c6f8e6/src/flask_socketio/test_client.py#L179 --- stubs/Flask-SocketIO/flask_socketio/test_client.pyi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stubs/Flask-SocketIO/flask_socketio/test_client.pyi b/stubs/Flask-SocketIO/flask_socketio/test_client.pyi index cf7eb153405e..62f27781c868 100644 --- a/stubs/Flask-SocketIO/flask_socketio/test_client.pyi +++ b/stubs/Flask-SocketIO/flask_socketio/test_client.pyi @@ -29,7 +29,7 @@ class SocketIOTestClient: auth: dict[str, Incomplete] | None = None, ) -> None: ... def disconnect(self, namespace: str | None = None) -> None: ... - def emit(self, event: str, *args, callback: bool = True, namespace: str | None = None) -> Incomplete | None: ... + def emit(self, event: str, *args, callback: bool = False, namespace: str | None = None) -> Incomplete | None: ... def send( self, data: str | dict[str, Incomplete] | list[Incomplete],