Skip to content

Timeline chart not displayed #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
isshiki opened this issue Jun 24, 2019 · 3 comments · Fixed by #242
Closed

Timeline chart not displayed #241

isshiki opened this issue Jun 24, 2019 · 3 comments · Fixed by #242

Comments

@isshiki
Copy link
Contributor

isshiki commented Jun 24, 2019

timeline-chart

I think that the timeline chart was displayed here when I saw timeline-section a week ago.
But, that is not displayed today.
@isshiki isshiki changed the title Timeline char not displayed Timeline chart not displayed Jun 24, 2019
@isshiki
Copy link
Contributor Author

isshiki commented Jun 24, 2019

error

I found a javascript error.
It may be the cause?

@takluyver
Copy link
Member

Yes, that's probably the cause. Do you want to make a PR fixing it?

This isn't the first time that's been broken. Maybe we should set up some simple CI to validate the JS syntax.

@isshiki
Copy link
Contributor Author

isshiki commented Jun 24, 2019

Thank you.
OK. I will make PR.

@isshiki isshiki mentioned this issue Jun 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix site.js json isshiki/python3statement.github.io
2 participants
@isshiki @takluyver