Skip to content

📖 [Story] Sharing Components between Torch export and compile Paths in Torch-TRT #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gs-olive opened this issue May 22, 2023 · 1 comment
Assignees
Labels
Story: Export/Compile Unification Issues relating to unification of Dynamo compile/export paths

Comments

@gs-olive
Copy link
Collaborator

TL;DR

Many of the existing and future proposed components for the torch_tensorrt.dynamo.fx_ts_compat (Torch export) and torch_tensorrt.dynamo.backend (Torch compile) paths are common between the two. This includes some lowering phases, aten converters, certain aspects of partitioning, and TRT modules. The goal of this story is to improve the unification between the two frontends to streamline the codebase and reduce code replication.

Goal(s)

  • Unification of the components used in the torch_tensorrt.dynamo.fx_ts_compat (Torch export) and torch_tensorrt.dynamo.backend (Torch compile) paths
  • Improving code cleanliness and reducing code replication
  • Centralizing component/unit tests
  • Increasing speed to diagnose, fix, and push changes for key issues

Implementation Phases

  1. Unify existing components of fx_ts_compat and backend that could reasonably be used together
  2. Combine lowering phases + testing for both paths
  3. Combine partitioning systems + testing for both paths (or determine plan/rationale for having two separate partitioning systems)
  4. Add a TRTInterpreter override class to dynamo for usage between the two frontends
  5. Add a TRTModule override class to dynamo for usage between the two frontends
@gs-olive gs-olive added Story Issues proposing a new Story Story: Export/Compile Unification Issues relating to unification of Dynamo compile/export paths and removed Story Issues proposing a new Story labels May 22, 2023
@gs-olive gs-olive self-assigned this May 22, 2023
@github-actions
Copy link

This issue has not seen activity for 90 days, Remove stale label or comment or this will be closed in 10 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Story: Export/Compile Unification Issues relating to unification of Dynamo compile/export paths
Projects
None yet
Development

No branches or pull requests

2 participants