Skip to content

✨[Feature] Move _C code out of _util.py #2121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gs-olive opened this issue Jul 18, 2023 · 2 comments
Closed

✨[Feature] Move _C code out of _util.py #2121

gs-olive opened this issue Jul 18, 2023 · 2 comments
Assignees
Labels
feature request New feature or request No Activity

Comments

@gs-olive
Copy link
Collaborator

Context

PR #2118 moves key version-checking functionality into a utilities file which imports _C. This file, _util.py needs to be refactored and/or imported differently to allow use of the utility without pulling in the C dependency, which is undesirable for users who prefer to use Python-only runtimes or install a lightweight version of the repository.

Proposal

See 38a2c4c for a potential solution. In short, one can move the _C-dependent utilities to the ts directory and update the imports, with a new utilities file being created in the main directory.

@narendasan
Copy link
Collaborator

Some of the _C code can be reimplemented in Python as well. Particularly the build_info stuff

@github-actions
Copy link

This issue has not seen activity for 90 days, Remove stale label or comment or this will be closed in 10 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request No Activity
Projects
None yet
Development

No branches or pull requests

2 participants