Skip to content

✨[Feature] Add GetITensor constant management system to Dynamo #2306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gs-olive opened this issue Sep 11, 2023 · 0 comments · Fixed by #2324
Closed

✨[Feature] Add GetITensor constant management system to Dynamo #2306

gs-olive opened this issue Sep 11, 2023 · 0 comments · Fixed by #2324
Assignees
Labels
feature request New feature or request

Comments

@gs-olive
Copy link
Collaborator

Context

In the TorchScript path of the codebase, tensors are accessed via the ITensorOrFreeze function, as below:

nvinfer1::ITensor* Var::ITensorOrFreeze(ConversionCtx* ctx) {

This function serves to freeze any input constants before returning them. Such a utility would be very useful in Dynamo, to handle cases where converters cannot process Numpy array or Torch Tensor inputs (like aten.cat, for example).

Converters could use this function when a certain input is required to be an ITensor, and omit it when this is not required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant