Filter options in scipy minimize to avoid passing in method as option (#75)

Balandat · facebook-github-bot · commit 2b3fe699882c · 2019-04-22T16:52:24.000-07:00
Summary: Gets rid of the `OptimizeWarnings` issued in newer scipy versions if an unknown option is passed in. Pull Request resolved: #75 Reviewed By: danielrjiang Differential Revision: D15039022 Pulled By: Balandat fbshipit-source-id: a1a74f8607b306a5f8018ea27968ff6f71a78997
diff --git a/botorch/gen.py b/botorch/gen.py
@@ -98,7 +98,7 @@ def f(x):
         jac=True,
         bounds=bounds,
         constraints=constraints,
-        options=options,
+        options={k: v for k, v in options.items() if k != "method"},
     )
     candidates = fix_features(
         X=torch.from_numpy(res.x)  # pyre-ignore [16]

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ def f(x):`
`98`	`98`	`jac=True,`
`99`	`99`	`bounds=bounds,`
`100`	`100`	`constraints=constraints,`
`101`		`- options=options,`
	`101`	`+ options={k: v for k, v in options.items() if k != "method"},`
`102`	`102`	`)`
`103`	`103`	`candidates = fix_features(`
`104`	`104`	`X=torch.from_numpy(res.x) # pyre-ignore [16]`