Skip to content

Commit 8593092

Browse files
authored
Revert "conda: add _GLIBCXX_USE_CXX11_ABI=1 support for linux cpu wheel (#1062)" (#1086)
This reverts commit af69c3e.
1 parent af69c3e commit 8593092

File tree

6 files changed

+6
-76
lines changed

6 files changed

+6
-76
lines changed

conda/Dockerfile_cxx11-abi

Lines changed: 0 additions & 50 deletions
This file was deleted.

conda/build_all_docker.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ set -eou pipefail
44

55
TOPDIR=$(git rev-parse --show-toplevel)
66

7-
for CUDA_VERSION in 11.7 11.6 11.5 11.3 10.2 cpu cpu-cxx11-abi; do
7+
for CUDA_VERSION in 11.7 11.6 11.5 11.3 10.2 cpu; do
88
CUDA_VERSION="${CUDA_VERSION}" conda/build_docker.sh
99
done

conda/build_docker.sh

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,12 @@ DEVTOOLSET_VERSION="9"
1010
if [[ ${CUDA_VERSION:0:2} == "10" ]]; then
1111
DEVTOOLSET_VERSION="7"
1212
fi
13-
CONDA_LINUX_VERSION=${CONDA_LINUX_VERSION:-}
1413

1514
case ${CUDA_VERSION} in
1615
cpu)
1716
BASE_TARGET=base
1817
DOCKER_TAG=cpu
1918
;;
20-
cpu-cxx11-abi)
21-
BASE_TARGET=base
22-
DOCKER_TAG=cpu-cxx11-abi
23-
CONDA_LINUX_VERSION="cxx11-abi"
24-
;;
2519
all)
2620
BASE_TARGET=all_cuda
2721
DOCKER_TAG=latest
@@ -32,12 +26,6 @@ case ${CUDA_VERSION} in
3226
;;
3327
esac
3428

35-
if [[ -n ${CONDA_LINUX_VERSION} ]]; then
36-
DOCKERFILE_SUFFIX=_${CONDA_LINUX_VERSION}
37-
else
38-
DOCKERFILE_SUFFIX=''
39-
fi
40-
4129
(
4230
set -x
4331
docker build \
@@ -46,7 +34,7 @@ fi
4634
--build-arg "CUDA_VERSION=${CUDA_VERSION}" \
4735
--build-arg "DEVTOOLSET_VERSION=${DEVTOOLSET_VERSION}" \
4836
-t "pytorch/conda-builder:${DOCKER_TAG}" \
49-
-f "${TOPDIR}/conda/Dockerfile${DOCKERFILE_SUFFIX}" \
37+
-f "${TOPDIR}/conda/Dockerfile" \
5038
${TOPDIR}
5139
)
5240

conda/build_pytorch.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ else
4949
build_version="$2"
5050
build_number="$3"
5151
fi
52-
if [[ "$desired_cuda" != cpu ]] && [[ "$desired_cuda" != cpu-cxx11-abi ]]; then
52+
if [[ "$desired_cuda" != cpu ]]; then
5353
desired_cuda="$(echo $desired_cuda | tr -d cuda. )"
5454
fi
5555
echo "Building cuda version $desired_cuda and pytorch version: $build_version build_number: $build_number"
@@ -108,7 +108,7 @@ fi
108108
if [[ "$OSTYPE" == "darwin"* ]]; then
109109
DEVELOPER_DIR=/Applications/Xcode9.app/Contents/Developer
110110
fi
111-
if [[ "$desired_cuda" == 'cpu' ]] || [[ "$desired_cuda" == 'cpu-cxx11-abi' ]]; then
111+
if [[ "$desired_cuda" == 'cpu' ]]; then
112112
cpu_only=1
113113
else
114114
# Switch desired_cuda to be M.m to be consistent with other scripts in

conda/pytorch-nightly/build.sh

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,8 @@ export CMAKE_PREFIX_PATH=$PREFIX
66
export TH_BINARY_BUILD=1 # links CPU BLAS libraries thrice in a row (was needed for some MKL static linkage)
77
export PYTORCH_BUILD_VERSION=$PKG_VERSION
88
export PYTORCH_BUILD_NUMBER=$PKG_BUILDNUM
9-
if [[ "$DESIRED_DEVTOOLSET" == *"cxx11-abi"* ]]; then
10-
export _GLIBCXX_USE_CXX11_ABI=1
11-
export USE_LLVM="/opt/llvm"
12-
export LLVM_DIR="$USE_LLVM/lib/cmake/llvm"
13-
else
14-
export _GLIBCXX_USE_CXX11_ABI=0
15-
export USE_LLVM="/opt/llvm_no_cxx11_abi"
16-
export LLVM_DIR="$USE_LLVM/lib/cmake/llvm"
17-
fi
9+
export USE_LLVM="/opt/llvm_no_cxx11_abi"
10+
export LLVM_DIR="$USE_LLVM/lib/cmake/llvm"
1811

1912
# set OPENSSL_ROOT_DIR=/opt/openssl if it exists
2013
if [[ -e /opt/openssl ]]; then

conda/pytorch-nightly/meta.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ build:
7070
- DEVELOPER_DIR
7171
- DEBUG
7272
- USE_FBGEMM
73-
- DESIRED_DEVTOOLSET
7473
- USE_GLOO_WITH_OPENSSL # [unix]
7574
- USE_SCCACHE # [win]
7675
- USE_DISTRIBUTED # [unix]

0 commit comments

Comments
 (0)