Skip to content

The developer install instruction are outdated #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pmeier opened this issue May 20, 2022 · 3 comments
Closed

The developer install instruction are outdated #432

pmeier opened this issue May 20, 2022 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@pmeier
Copy link
Contributor

pmeier commented May 20, 2022

data/CONTRIBUTING.md

Lines 49 to 56 in 6a8415b

### Install TorchData
```bash
git clone https://github.com/pytorch/data.git
cd data
python setup.py develop
pip install flake8 typing mypy pytest expecttest
```

While debugging #418 it took my quite a while to figure out that I need to set

_BUILD_S3 = _get_build("BUILD_S3", False)

for the C++ code to be built.

@ejguan
Copy link
Contributor

ejguan commented May 20, 2022

Thanks for pointing out. The documents are updated to the wrong location: https://github.com/pytorch/data/tree/main/torchdata/datapipes/iter/load#installation

Will fix it

@ejguan ejguan added the documentation Improvements or additions to documentation label May 20, 2022
@ejguan ejguan linked a pull request May 25, 2022 that will close this issue
@NivekT
Copy link
Contributor

NivekT commented Jun 10, 2022

@ejguan Can we close this as #464 has landed?

@ejguan
Copy link
Contributor

ejguan commented Jun 10, 2022

Yeah. Closing this issue as the fix has landed.

@ejguan ejguan closed this as completed Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants