Skip to content

Commit 6e7028e

Browse files
authored
Merge branch 'main' into gh/mcr229/29/head
2 parents 08f8e51 + d4cc258 commit 6e7028e

File tree

5 files changed

+8
-9
lines changed

5 files changed

+8
-9
lines changed

docs/source/using-executorch-building-from-source.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ Or alternatively, [install conda on your machine](https://conda.io/projects/cond
6464
# Intel-based macOS systems require building PyTorch from source (see below)
6565
./install_executorch.sh
6666
```
67-
68-
See the [PyTorch instructions](https://github.com/pytorch/pytorch#installation) on how to build PyTorch from source.
67+
68+
See the [PyTorch instructions](https://github.com/pytorch/pytorch#installation) on how to build PyTorch from source.
6969

7070
Use the [`--use-pt-pinned-commit` flag](../../install_executorch.py) to install ExecuTorch with an existing PyTorch build:
7171

@@ -90,7 +90,7 @@ Or alternatively, [install conda on your machine](https://conda.io/projects/cond
9090

9191
# Or you can directly do the following if dependencies are already installed
9292
# either via a previous invocation of `./install_executorch.sh` or by explicitly installing requirements via `./install_requirements.sh` first.
93-
pip install -e .
93+
pip install -e . --no-build-isolation
9494
```
9595

9696
If C++ files are being modified, you will still have to reinstall ExecuTorch from source.
@@ -243,7 +243,7 @@ Install ClangCL for Windows from the [official website](https://learn.microsoft.
243243
To check if conda is detected by the powershell prompt, try `conda list` or `conda --version`
244244
245245
If conda is not detected, you could run the powershell script for conda named `conda-hook.ps1`.
246-
To verify that Conda is available in the in the powershell environment, run try `conda list` or `conda --version`.
246+
To verify that Conda is available in the in the powershell environment, run try `conda list` or `conda --version`.
247247
If Conda is not available, run conda-hook.ps1 as follows:
248248
```bash
249249
$miniconda_dir\\shell\\condabin\\conda-hook.ps1

install_executorch.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
install_optional_example_requirements,
2020
install_requirements,
2121
python_is_compatible,
22-
TORCH_NIGHTLY_URL,
2322
)
2423

2524
# Set up logging
@@ -208,8 +207,6 @@ def main(args):
208207
".",
209208
"--no-build-isolation",
210209
"-v",
211-
"--extra-index-url",
212-
TORCH_NIGHTLY_URL,
213210
]
214211
)
215212
subprocess.run(cmd, check=True)

pyproject.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ requires = [
77
"tomli", # Imported by extract_sources.py when using python < 3.11.
88
"wheel", # For building the pip package archive.
99
"zstd", # Imported by resolve_buck.py.
10+
"certifi", # Imported by resolve_buck.py.
1011
]
1112
build-backend = "setuptools.build_meta"
1213

@@ -49,7 +50,7 @@ classifiers = [
4950
]
5051

5152
# Python dependencies required for use.
52-
# coremltools has issue with python 3.13, see https://github.com/apple/coremltools/issues/2487
53+
# coremltools has issue with python 3.13, see https://github.com/apple/coremltools/issues/2487
5354
requires-python = ">=3.10,<3.13"
5455
dependencies=[
5556
"expecttest",

requirements-dev.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ setuptools>=63 # For building the pip package contents.
77
tomli # Imported by extract_sources.py when using python < 3.11.
88
wheel # For building the pip package archive.
99
zstd # Imported by resolve_buck.py.
10+
certifi # Imported by resolve_buck.py.
1011
lintrunner==0.12.7
1112
lintrunner-adapters==0.12.4
1213
hydra-core>=1.3.0

tools/cmake/Utils.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ function(resolve_buck2)
128128

129129
set(resolve_buck2_command
130130
${PYTHON_EXECUTABLE} ${executorch_root}/tools/cmake/resolve_buck.py
131-
--cache_dir=buck2-bin
131+
--cache_dir=${executorch_root}/buck2-bin
132132
)
133133

134134
if(NOT ${BUCK2} STREQUAL "")

0 commit comments

Comments
 (0)