Skip to content

Commit e115a25

Browse files
committed
Include custom_ops and XNNPACK in executor_runner if built
Somebody (larryliu0820?) pointed out that there's no particular reason to require a separate xnn_executor_runner target, and indeed we already put several other optimized things in here if they're built. ghstack-source-id: e408855 ghstack-comment-id: 2722889450 Pull Request resolved: #9248
1 parent cfd0bc4 commit e115a25

File tree

3 files changed

+15
-2
lines changed

3 files changed

+15
-2
lines changed

.github/workflows/pull.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -361,6 +361,7 @@ jobs:
361361
CONDA_ENV=$(conda env list --json | jq -r ".envs | .[-1]")
362362
conda activate "${CONDA_ENV}"
363363
364+
./install_requirements.sh --use-pt-pinned-comit
364365
# build module for executorch.extension.pybindings.portable_lib
365366
bash test/build_size_test.sh
366367
strip cmake-out/test/size_test
@@ -396,6 +397,8 @@ jobs:
396397
CONDA_ENV=$(conda env list --json | jq -r ".envs | .[-1]")
397398
conda activate "${CONDA_ENV}"
398399
400+
./install_requirements.sh --use-pt-pinned-comit
401+
399402
# build module for executorch.extension.pybindings.portable_lib
400403
bash test/build_size_test.sh
401404
strip cmake-out/test/size_test
@@ -510,6 +513,7 @@ jobs:
510513
MODE=${{ matrix.mode }}
511514
PT2E_QUANTIZE=${{ matrix.pt2e_quantize }}
512515
516+
./install_requirements.sh --use-pt-pinned-commit
513517
PYTHON_EXECUTABLE=python bash .ci/scripts/setup-qnn-deps.sh
514518
PYTHON_EXECUTABLE=python bash .ci/scripts/build-qnn-sdk.sh
515519
@@ -541,6 +545,7 @@ jobs:
541545
542546
BUILD_TOOL="cmake"
543547
548+
./install_requirements.sh --use-pt-pinned-commit
544549
PYTHON_EXECUTABLE=python bash .ci/scripts/setup-qnn-deps.sh
545550
PYTHON_EXECUTABLE=python bash .ci/scripts/build-qnn-sdk.sh
546551

CMakeLists.txt

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
# It should also be cmake-lint clean.
4343
#
4444

45-
cmake_minimum_required(VERSION 3.19)
45+
cmake_minimum_required(VERSION 3.24)
4646
project(executorch)
4747
include(build/Utils.cmake)
4848
include(CMakeDependentOption)
@@ -914,6 +914,14 @@ if(EXECUTORCH_BUILD_EXECUTOR_RUNNER)
914914
list(APPEND _executor_runner_libs quantized_ops_lib)
915915
endif()
916916

917+
if(EXECUTORCH_BUILD_KERNELS_CUSTOM)
918+
list(APPEND _executor_runner_libs $<LINK_LIBRARY:WHOLE_ARCHIVE,custom_ops>)
919+
endif()
920+
921+
if(EXECUTORCH_BUILD_XNNPACK)
922+
list(APPEND _executor_runner_libs xnnpack_backend)
923+
endif()
924+
917925
if(EXECUTORCH_ENABLE_EVENT_TRACER)
918926
if(EXECUTORCH_BUILD_DEVTOOLS)
919927
list(APPEND _executor_runner_libs etdump flatccrt)

backends/xnnpack/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ include(cmake/Dependencies.cmake)
9797
list(TRANSFORM _xnnpack_backend__srcs PREPEND "${EXECUTORCH_ROOT}/")
9898
add_library(xnnpack_backend STATIC ${_xnnpack_backend__srcs})
9999
target_link_libraries(
100-
xnnpack_backend PRIVATE ${xnnpack_third_party} executorch_core xnnpack_schema
100+
xnnpack_backend PUBLIC ${xnnpack_third_party} executorch_core xnnpack_schema extension_threadpool
101101
)
102102

103103
target_include_directories(

0 commit comments

Comments
 (0)