From 9acab94c705d944d07e14af25d84de9d912f3ac3 Mon Sep 17 00:00:00 2001 From: Scott Roy Date: Fri, 12 Apr 2024 14:08:35 -0700 Subject: [PATCH] Remove RemoveRedundantViewCopyPass (#2464) Summary: The RemoveRedundantViewCopyPass is unnecessary and can be replaced by NormalizeViewCopyBasePass + dead code elimintation. Reviewed By: larryliu0820 Differential Revision: D54866523 --- exir/passes/normalize_view_copy_base_pass.py | 2 -- exir/program/_program.py | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/exir/passes/normalize_view_copy_base_pass.py b/exir/passes/normalize_view_copy_base_pass.py index 7ff1346da5a..2c98a8525d4 100644 --- a/exir/passes/normalize_view_copy_base_pass.py +++ b/exir/passes/normalize_view_copy_base_pass.py @@ -29,8 +29,6 @@ class NormalizeViewCopyBasePass(PassBase): When combined with dead-code elimination, this pass removes redundant view_copy nodes. - - TODO: replace RemoveRedundantViewCopyPass with NormalizeViewCopyBasePass + dead code elimination. """ def call(self, graph_module: torch.fx.GraphModule) -> PassResult: diff --git a/exir/program/_program.py b/exir/program/_program.py index 086768b879d..8b6e84b000b 100644 --- a/exir/program/_program.py +++ b/exir/program/_program.py @@ -24,6 +24,7 @@ from executorch.exir.passes import ( base_post_op_replace_passes, base_pre_op_replace_passes, + dead_code_elimination_pass, EdgeToBackendOpsPass, MemoryFormatOpsPass, OpReplacePass, @@ -626,6 +627,7 @@ def pre_memory_planning_passes(config: ExecutorchBackendConfig) -> List[PassType # pyre-ignore return [ NormalizeViewCopyBasePass(), + dead_code_elimination_pass, ReplaceViewCopyWithViewPass(), config.sym_shape_eval_pass, config.to_out_var_pass,