address comments

Author: jackm321

lib/Onnxifi/Base.cpp

@@ -23,8 +23,8 @@
 namespace glow {
 namespace onnxifi {
 namespace {
-const std::string inferenceFunctionName = "inference";
-const std::string compatibilityFunctionName = "check";
+const char *inferenceFunctionName = "inference";
+const char *compatibilityFunctionName = "check";
 } // namespace
 
 onnxStatus BackendId::checkGraphCompatibility(const void *onnxModel,
@@ -156,7 +156,7 @@ void Graph::run(
     phs.push_back(var);
   }
 
-  auto ctx = std::make_unique<Context>();
+  auto ctx = llvm::make_unique<Context>();
 
   // Run inference.
   auto &EE = backendPtr_->getEE();

lib/Onnxifi/Base.h

@@ -34,7 +34,9 @@ namespace onnxifi {
 
 // TODO get rid of this once HostManager is landed.
 struct HostManager {
-  bool addNetwork(Module *M) { return true; }
+  bool addNetwork(Module *M) {
+    llvm_unreachable("HostManager is not yet implemented.");
+  }
 };
 
 // TODO use the actual type here once available.
@@ -45,8 +47,11 @@ using ResultCBTy =
 class BackendId {
 public:
   /// Create Glow ONNXIFI backend identifier with the
-  /// given Glow backend \p kind, \p id, \p concurrency and whether to use onnx
-  /// or caffe2 for models (\p use_onnx).
+  /// given Glow backend \p kind, \p id, \p concurrency, whether to use onnx
+  /// or caffe2 for models (\p useInnx), and whether to use HostManager instead
+  /// of ExecutionEngine for running graphs (useHostManager).
+  /// NOTE: useHostManager is not yet supported as HostManager is yet to be
+  /// fully implemented.
   explicit BackendId(glow::BackendKind kind, int id, int concurrency,
                      bool useOnnx, bool useHostManager)
       : id_(id), useOnnx_(useOnnx), concurrency_(concurrency),

lib/Onnxifi/onnxifiGlow.cpp

@@ -104,7 +104,7 @@ GLOW_ONNXIFI_LIBRARY_FUNCTION_WRAPPER(onnxGetBackendIDs)(
       /*id*/ 2, /*concurrency*/ 1, /*useOnnx*/ false, /*useHostManager*/ false);
   auto *interpreterBackendC2HostManager = new glow::onnxifi::BackendId(
       glow::BackendKind::Interpreter,
-      /*id*/ 2, /*concurrency*/ 1, /*useOnnx*/ false, /*useOnnx*/ false,
+      /*id*/ 2, /*concurrency*/ 1, /*useOnnx*/ false,
       /*useHostManager*/ true);
 
   manager.addBackendId(interpreterBackendOnnx);