You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Was browsing the codebase and noticed that we are overloading std::to_string for Glow's Type class. Not to be that guy, but this is undefined behavior as per the standard (only allowed to explicitly specialize templates for user-defined types).
Not sure if we care? If we do, we should probably move that to Type::to_string or something.
Was browsing the codebase and noticed that we are overloading
std::to_string
for Glow'sType
class. Not to be that guy, but this is undefined behavior as per the standard (only allowed to explicitly specialize templates for user-defined types).Not sure if we care? If we do, we should probably move that to
Type::to_string
or something.Source: https://stackoverflow.com/questions/14402990/should-you-overload-swap-in-the-std-namespace
The text was updated successfully, but these errors were encountered: