Update on "move //tools/codegen:codegen into shared build structure"

This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]

Author: Michael Andreas Dagitses

.circleci/docker/build.sh

@@ -222,21 +222,21 @@ case "$image" in
     DB=yes
     VISION=yes
     ;;
-  pytorch-linux-bionic-rocm4.3.1-py3.7)
+  pytorch-linux-bionic-rocm4.5-py3.7)
     ANACONDA_PYTHON_VERSION=3.7
     GCC_VERSION=9
     PROTOBUF=yes
     DB=yes
     VISION=yes
-    ROCM_VERSION=4.3.1
+    ROCM_VERSION=4.5.2
     ;;
-  pytorch-linux-bionic-rocm4.5-py3.7)
+  pytorch-linux-bionic-rocm5.0-py3.7)
     ANACONDA_PYTHON_VERSION=3.7
     GCC_VERSION=9
     PROTOBUF=yes
     DB=yes
     VISION=yes
-    ROCM_VERSION=4.5.2
+    ROCM_VERSION=5.0
     ;;
   *)
     # Catch-all for builds that are not hardcoded.

.circleci/docker/common/install_rocm.sh

@@ -35,7 +35,7 @@ ver() {
 }
 
 # Map ROCm version to AMDGPU version
-declare -A AMDGPU_VERSIONS=( ["4.5.2"]="21.40.2" )
+declare -A AMDGPU_VERSIONS=( ["4.5.2"]="21.40.2" ["5.0"]="21.50" )
 
 install_ubuntu() {
     apt-get update

.github/actions/teardown-linux/action.yml

@@ -3,8 +3,8 @@ name: Teardown Linux
 description: Stuff that should always run at the end of a linux job
 
 inputs:
-  wait-ssh:
-    description: If set, wait for ssh to drain before tearing down
+  skip-wait-ssh:
+    description: If set, don't wait for ssh to drain before tearing down
     required: false
     default: ""
 
@@ -15,7 +15,7 @@ runs:
       # TODO working-directory: !{{ pytorch_directory }}
       # Always hold for active ssh sessions
       shell: bash
-      if: inputs.wait-ssh != ''
+      if: inputs.skip-wait-ssh == ''
       run: .github/scripts/wait_for_ssh_to_drain.sh
 
     - name: Kill containers, clean up images

.github/merge_rules.json

@@ -26,7 +26,7 @@
    {
       "name": "OSS CI",
       "patterns": [".github/**", ".circleci/**", ".jenkins/**", "scripts/**", "tools/**"],
-      "approved_by": ["janeyx99", "ezyang", "atalman"],
+      "approved_by": ["ezyang", "pytorch/pytorch-dev-infra"],
       "mandatory_checks_name": ["Facebook CLA Check", "Lint"]
    },
    {
@@ -36,62 +36,86 @@
       "mandatory_checks_name": ["Facebook CLA Check", "Lint"]
    },
    {
-      "name": "Android",
-      "patterns": ["android/**", "test/mobile/**"],
-      "approved_by": ["linbinyu", "kit1980", "IvanKobzarev"],
-      "mandatory_checks_name": ["Facebook CLA Check", "Lint"]
-   },
-   {
-      "name": "iOS",
-      "patterns": ["ios/**", "test/mobile/**"],
-      "approved_by": ["linbinyu", "kit1980", "xta0", "hanton"],
+      "name": "Mobile",
+      "patterns": ["ios/**", "android/**", "test/mobile/**"],
+      "approved_by": ["linbinyu", "kit1980", "IvanKobzarev", "dreiss"],
       "mandatory_checks_name": ["Facebook CLA Check", "Lint"]
    },
    {
       "name": "superuser",
       "patterns": ["*"],
       "approved_by": [
+        "aaronenyeshi",
+        "alanwaketan",
         "albanD",
+        "angelayi",
+        "anijain2305",
         "anjali411",
+        "ansley",
         "awgu",
+        "bertmaher",
         "bdhirsh",
         "cbalioglu",
+        "Chillee",
         "cpuhrsch",
         "dagitses",
+        "davidberard98",
+        "desertfire",
+        "eellison",
         "ejguan",
         "ezyang",
         "fduwjj",
+        "Gamrix",
         "gchanan",
         "george-qi",
+        "gmagogsfm",
+        "hlu1",
+        "huiguoo",
         "H-Huang",
         "jaceyca",
         "jamesr66a",
+        "jansel",
         "jbschlosser",
         "jiayisuse",
+        "Krovatkin",
         "kumpera",
         "kwen2501",
         "malfet",
         "mikaylagawarecki",
+        "mikeiovine",
         "mingzhe09088",
         "mrshenli",
         "mruberry",
+        "navahgar",
         "ngimel",
+        "NicolasHug",
+        "nikithamalgifb",
         "NivekT",
         "osalpekar",
+        "PaliC",
         "pbelevich",
         "pritamdamania87",
+        "qihqi",
+        "robieta",
         "rohan-varma",
         "saketh-are",
         "samdow",
         "seemethere",
         "SherlockNoMad",
+        "shunting314",
         "soulitzer",
         "suo",
+        "tugsbayasgalan",
         "VitalyFedyunin",
+        "vmoens",
         "wanchaol",
+        "wconstab",
         "wenleix",
         "yaroslavvb",
+        "zdevito",
         "zhaojuanmao",
+        "zhxchen17",
+        "ZolotukhinM",
         "zou3519"
       ],
       "mandatory_checks_name": ["Facebook CLA Check", "Lint"]

.github/scripts/generate_binary_build_matrix.py

@@ -59,6 +59,14 @@ def arch_type(arch_version: str) -> str:
         (gpu_arch, CXX11_ABI): f"pytorch/libtorch-cxx11-builder:cuda{gpu_arch}"
         for gpu_arch in CUDA_ARCHES
     },
+    **{
+        (gpu_arch, PRE_CXX11_ABI): f"pytorch/manylinux-builder:rocm{gpu_arch}"
+        for gpu_arch in ROCM_ARCHES
+    },
+    **{
+        (gpu_arch, CXX11_ABI): f"pytorch/libtorch-cxx11-builder:rocm{gpu_arch}"
+        for gpu_arch in ROCM_ARCHES
+    },
     ("cpu", PRE_CXX11_ABI): "pytorch/manylinux-builder:cpu",
     ("cpu", CXX11_ABI): "pytorch/libtorch-cxx11-builder:cpu",
 }
@@ -119,6 +127,7 @@ def generate_libtorch_matrix(os: str, abi_version: str,
         arches = ["cpu"]
         if os == "linux":
             arches += CUDA_ARCHES
+            arches += ROCM_ARCHES
         elif os == "windows":
             # We don't build CUDA 10.2 for window see https://github.com/pytorch/pytorch/issues/65648
             arches += list_without(CUDA_ARCHES, ["10.2"])
@@ -134,7 +143,6 @@ def generate_libtorch_matrix(os: str, abi_version: str,
     ret: List[Dict[str, str]] = []
     for arch_version in arches:
         for libtorch_variant in libtorch_variants:
-            # We don't currently build libtorch for rocm
             # one of the values in the following list must be exactly
             # CXX11_ABI, but the precise value of the other one doesn't
             # matter

.github/scripts/generate_ci_workflows.py

@@ -667,8 +667,8 @@ def generate_workflow_file(self, workflow_template: jinja2.Template) -> None:
     ),
     CIWorkflow(
         arch="linux",
-        build_environment="linux-bionic-rocm4.5-py3.7",
-        docker_image_base=f"{DOCKER_REGISTRY}/pytorch/pytorch-linux-bionic-rocm4.5-py3.7",
+        build_environment="linux-bionic-rocm5.0-py3.7",
+        docker_image_base=f"{DOCKER_REGISTRY}/pytorch/pytorch-linux-bionic-rocm5.0-py3.7",
         test_runner_type=LINUX_ROCM_TEST_RUNNER,
         num_test_shards=2,
         enable_distributed_test=False,
@@ -936,8 +936,8 @@ def generate_workflow_file(self, workflow_template: jinja2.Template) -> None:
 ]
 
 DOCKER_IMAGES = {
-    f"{DOCKER_REGISTRY}/pytorch/pytorch-linux-bionic-rocm4.3.1-py3.7",               # for rocm
-    f"{DOCKER_REGISTRY}/pytorch/pytorch-linux-bionic-rocm4.5-py3.7",                 # for rocm
+    f"{DOCKER_REGISTRY}/pytorch/pytorch-linux-bionic-rocm4.5-py3.7",               # for rocm
+    f"{DOCKER_REGISTRY}/pytorch/pytorch-linux-bionic-rocm5.0-py3.7",                 # for rocm
 }
 
 DOCKER_IMAGES.update({

.github/scripts/gql_mocks.json

@@ -2,7 +2,7 @@
 import json
 import os
 from hashlib import sha256
-from trymerge import find_matching_merge_rule, gh_graphql, GitHubPR
+from trymerge import find_matching_merge_rule, gh_graphql, gh_get_team_members, GitHubPR
 from gitutils import get_git_remote_name, get_git_repo_dir, GitRepo
 from typing import Any
 from unittest import TestCase, main, mock
@@ -106,6 +106,15 @@ def test_gql_complexity(self, mocked_gql: Any) -> None:
         self.assertGreater(len(pr.get_checkrun_conclusions()), 3)
         self.assertGreater(pr.get_commit_count(), 60)
 
+    @mock.patch('trymerge.gh_graphql', side_effect=mocked_gh_graphql)
+    def test_team_members(self, mocked_gql: Any) -> None:
+        "Test fetching team members works"
+        dev_infra_team = gh_get_team_members("pytorch", "pytorch-dev-infra")
+        self.assertGreater(len(dev_infra_team), 2)
+        with self.assertWarns(Warning):
+            non_existing_team = gh_get_team_members("pytorch", "qwertyuiop")
+            self.assertEqual(len(non_existing_team), 0)
+
 
 if __name__ == "__main__":
     main()