Skip to content

Commit c5e6d94

Browse files
committed
Update on "[reland] Update tls logic to work better with guarded call (#73925)"
This PR relands #73925 which we reverted due to a large breakage in functorch. As a part of the reland, this PR adds a change we agreed upon in https://docs.google.com/document/d/1i7Y9VZp9PxtgVcrQh6nGQXkXkPc1uMep0dM-OMOGJ9o/edit The change is moving the PythonTLSSnapshot key after DynamicLayerFrontMode. Test Plan: - I tested this with an updated version of functorch and all the tests pass so I think we are out of the woods. [ghstack-poisoned]
2 parents de281be + 9e4a26a commit c5e6d94

File tree

146 files changed

+3278
-27381
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

146 files changed

+3278
-27381
lines changed

.circleci/docker/common/install_rocm.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ install_magma() {
66
# "install" hipMAGMA into /opt/rocm/magma by copying after build
77
git clone https://bitbucket.org/icl/magma.git
88
pushd magma
9-
# fix for magma_queue memory leak issue
10-
git checkout c62d700d880c7283b33fb1d615d62fc9c7f7ca21
9+
# Fixes memory leaks of magma found while executing linalg UTs
10+
git checkout 5959b8783e45f1809812ed96ae762f38ee701972
1111
cp make.inc-examples/make.inc.hip-gcc-mkl make.inc
1212
echo 'LIBDIR += -L$(MKLROOT)/lib' >> make.inc
1313
echo 'LIB += -Wl,--enable-new-dtags -Wl,--rpath,/opt/rocm/lib -Wl,--rpath,$(MKLROOT)/lib -Wl,--rpath,/opt/rocm/magma/lib' >> make.inc

.circleci/scripts/binary_linux_test.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,8 @@ mv /final_pkgs/debug-*.zip /tmp/debug_final_pkgs || echo "no debug packages to m
6767
# TODO there is duplicated and inconsistent test-python-env setup across this
6868
# file, builder/smoke_test.sh, and builder/run_tests.sh, and also in the
6969
# conda build scripts themselves. These should really be consolidated
70-
pkg="/final_pkgs/\$(ls /final_pkgs)"
70+
# Pick only one package of multiple available (which happens as result of workflow re-runs)
71+
pkg="/final_pkgs/\$(ls -1 /final_pkgs|sort|tail -1)"
7172
if [[ "$PACKAGE_TYPE" == conda ]]; then
7273
(
7374
# For some reason conda likes to re-activate the conda environment when attempting this install

.github/actions/setup-win/action.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: Setup Windows
22

3-
description: Set up Docker workspace on linux
3+
description: Set up for windows jobs
44

55
inputs:
66
github-secret:
@@ -56,7 +56,7 @@ runs:
5656
.circleci/scripts/windows_cuda_install.sh
5757
.circleci/scripts/windows_cudnn_install.sh
5858
59-
- uses: actions/setup-python@v2
60-
name: Setup Python3
59+
- name: Setup Python3
60+
uses: actions/setup-python@v2
6161
with:
6262
python-version: "3.x"

.github/generated-ciflow-ruleset.json

Lines changed: 0 additions & 248 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)