Skip to content

[quantization] Need kernels for broadcasting ops #24210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
z-a-f opened this issue Aug 12, 2019 · 2 comments
Closed

[quantization] Need kernels for broadcasting ops #24210

z-a-f opened this issue Aug 12, 2019 · 2 comments
Assignees
@z-a-f
Labels
oncall: quantization Quantization support in PyTorch quantization_release_1.3 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@z-a-f
Copy link

z-a-f commented Aug 12, 2019

🚀 Feature

Need to support broadcasting for the quantized operations.
Currently only quantized add needs support for broadcasting
@z-a-f z-a-f self-assigned this Aug 12, 2019
@z-a-f z-a-f added quantization_release_1.3 oncall: quantization Quantization support in PyTorch labels Aug 12, 2019
@z-a-f z-a-f mentioned this issue Aug 13, 2019
Closed
@pietern pietern added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 13, 2019
@soumith soumith changed the title Need kernels for broadcasting ops [quantization] Need kernels for broadcasting ops Aug 13, 2019
@raghuramank100
Copy link
Contributor

Can you add more details (specific examples) or close this issue @z-a-f ?

@z-a-f
Copy link
Author

z-a-f commented Oct 15, 2019

We needed a scalar add and scalar multiply. They are landed as #25622, #25545, #24447, #24873, #25080. Closing it now, as there is no current need for other broadcasting ops

@z-a-f z-a-f closed this as completed Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@z-a-f z-a-f

Labels
oncall: quantization Quantization support in PyTorch quantization_release_1.3 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pietern @z-a-f @raghuramank100