Back out "JaggedTensor permute - less CPU ops" #2862
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72187365 |
Microve
added a commit
to Microve/torchrec
that referenced
this pull request
Apr 1, 2025
Summary: Original commit changeset: 257a9a45b204 Original Phabricator Diff: D70609204 The original diff causes our integration tests failing: https://fburl.com/mlhub/5kkga9zg Example of failed test job: f714668378 The error message is "AssertionError: inverse indices must be provided from KJT if using variable batch size per feature." Backout this diff to unblock our tests Differential Revision: D72187365
Microve
force-pushed
the
export-D72187365
branch
from
85bf139 to
f8c2251
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72187365 |
Microve
added a commit
to Microve/torchrec
that referenced
this pull request
Apr 1, 2025
Summary: Pull Request resolved: meta-pytorch#2862 Original commit changeset: 257a9a45b204 Original Phabricator Diff: D70609204 The original diff causes our integration tests failing: https://fburl.com/mlhub/q87huj8u Example of failed test job: f714668378 The error message is "AssertionError: inverse indices must be provided from KJT if using variable batch size per feature." Backout this diff to unblock our tests Differential Revision: D72187365
Microve
force-pushed
the
export-D72187365
branch
from
f8c2251 to
f36f91a
Compare
Summary: Original commit changeset: 257a9a45b204 Original Phabricator Diff: D70609204 The original diff causes our integration tests failing: https://fburl.com/mlhub/q87huj8u Example of failed test job: f714668378 The error message is "AssertionError: inverse indices must be provided from KJT if using variable batch size per feature." Backout this diff to unblock our tests Reviewed By: dshi7 Differential Revision: D72187365
Microve
force-pushed
the
export-D72187365
branch
from
f36f91a to
f20e8b5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72187365 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Original commit changeset: 257a9a45b204
Original Phabricator Diff: D70609204
The original diff causes our integration tests failing: https://fburl.com/mlhub/5kkga9zg
Example of failed test job: f714668378
The error message is "AssertionError: inverse indices must be provided from KJT if using variable batch size per feature."
Backout this diff to unblock our tests
Differential Revision: D72187365