Skip to content

Commit fc33c46

Browse files
authored
.circleci: Don't install numpy directly (#3444)
1 parent 67b2528 commit fc33c46

File tree

8 files changed

+8
-20
lines changed

8 files changed

+8
-20
lines changed

.circleci/config.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ jobs:
119119
command: |
120120
sudo apt-get update -y
121121
sudo apt install -y libturbojpeg-dev
122-
pip install --user --progress-bar off numpy mypy
122+
pip install --user --progress-bar off mypy
123123
pip install --user --progress-bar off --pre torch -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html
124124
pip install --user --progress-bar off --editable .
125125
mypy --config-file mypy.ini
@@ -153,7 +153,6 @@ jobs:
153153
- checkout
154154
- run:
155155
command: |
156-
pip install --user --progress-bar off numpy
157156
pip install --user --progress-bar off --pre torch -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html
158157
# need to install torchvision dependencies due to transitive imports
159158
pip install --user --progress-bar off --editable .
@@ -166,7 +165,6 @@ jobs:
166165
- checkout
167166
- run:
168167
command: |
169-
pip install --user --progress-bar off numpy
170168
pip install --user --progress-bar off --pre torch -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html
171169
# need to install torchvision dependencies due to transitive imports
172170
pip install --user --progress-bar off --editable .

.circleci/config.yml.in

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ jobs:
119119
command: |
120120
sudo apt-get update -y
121121
sudo apt install -y libturbojpeg-dev
122-
pip install --user --progress-bar off numpy mypy
122+
pip install --user --progress-bar off mypy
123123
pip install --user --progress-bar off --pre torch -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html
124124
pip install --user --progress-bar off --editable .
125125
mypy --config-file mypy.ini
@@ -153,7 +153,6 @@ jobs:
153153
- checkout
154154
- run:
155155
command: |
156-
pip install --user --progress-bar off numpy
157156
pip install --user --progress-bar off --pre torch -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html
158157
# need to install torchvision dependencies due to transitive imports
159158
pip install --user --progress-bar off --editable .
@@ -166,7 +165,6 @@ jobs:
166165
- checkout
167166
- run:
168167
command: |
169-
pip install --user --progress-bar off numpy
170168
pip install --user --progress-bar off --pre torch -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html
171169
# need to install torchvision dependencies due to transitive imports
172170
pip install --user --progress-bar off --editable .

.circleci/smoke_test/docker/Dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ RUN conda create -y --name python3.7 python=3.7
3030
RUN conda create -y --name python3.8 python=3.8
3131
SHELL [ "/bin/bash", "-c" ]
3232
RUN echo "source /usr/local/etc/profile.d/conda.sh" >> ~/.bashrc
33-
RUN source /usr/local/etc/profile.d/conda.sh && conda activate python3.6 && conda install -y numpy Pillow
34-
RUN source /usr/local/etc/profile.d/conda.sh && conda activate python3.7 && conda install -y numpy Pillow
35-
RUN source /usr/local/etc/profile.d/conda.sh && conda activate python3.8 && conda install -y numpy Pillow
33+
RUN source /usr/local/etc/profile.d/conda.sh && conda activate python3.6 && conda install -y Pillow
34+
RUN source /usr/local/etc/profile.d/conda.sh && conda activate python3.7 && conda install -y Pillow
35+
RUN source /usr/local/etc/profile.d/conda.sh && conda activate python3.8 && conda install -y Pillow
3636
CMD [ "/bin/bash"]

.circleci/unittest/linux/scripts/environment.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
channels:
22
- pytorch
33
- defaults
4-
# using conda-forge for python v3.9+
4+
# using conda-forge for python v3.9
55
- conda-forge
66
dependencies:
77
- pytest

.circleci/unittest/linux/scripts/install.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ else
2424
fi
2525

2626
printf "Installing PyTorch with %s\n" "${cudatoolkit}"
27-
conda install -y -c "pytorch-${UPLOAD_CHANNEL}" -c conda-forge pytorch "${cudatoolkit}"
27+
conda install -y -c "pytorch-${UPLOAD_CHANNEL}" -c conda-forge "pytorch-${UPLOAD_CHANNEL}"::pytorch "${cudatoolkit}"
2828

2929
printf "* Installing torchvision\n"
3030
python setup.py develop

.circleci/unittest/linux/scripts/setup_env.sh

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,10 @@ conda activate "${env_dir}"
3636

3737
# 3. Install Conda dependencies
3838
printf "* Installing dependencies (except PyTorch)\n"
39-
NUMPY_MIN_VER="1.11"
4039
FFMPEG_PIN="=4.2"
4140
if [[ "${PYTHON_VERSION}" = "3.9" ]]; then
42-
NUMPY_MIN_VER="1.20"
4341
FFMPEG_PIN=">=4.2"
4442
fi
4543

46-
conda install -y -c conda-forge "numpy >=${NUMPY_MIN_VER}"
4744
conda install -y -c pytorch "ffmpeg${FFMPEG_PIN}"
4845
conda env update --file "${this_dir}/environment.yml" --prune

.circleci/unittest/windows/scripts/install.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ else
2626
fi
2727

2828
printf "Installing PyTorch with %s\n" "${cudatoolkit}"
29-
conda install -y -c "pytorch-${UPLOAD_CHANNEL}" -c conda-forge pytorch "${cudatoolkit}"
29+
conda install -y -c "pytorch-${UPLOAD_CHANNEL}" -c conda-forge "pytorch-${UPLOAD_CHANNEL}"::pytorch "${cudatoolkit}"
3030

3131
printf "* Installing torchvision\n"
3232
"$this_dir/vc_env_helper.bat" python setup.py develop

.circleci/unittest/windows/scripts/setup_env.sh

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,4 @@ conda activate "${env_dir}"
3636

3737
# 3. Install Conda dependencies
3838
printf "* Installing dependencies (except PyTorch)\n"
39-
NUMPY_MIN_VER="1.11"
40-
if [[ "${PYTHON_VERSION}" = "3.9" ]]; then
41-
NUMPY_MIN_VER="1.20"
42-
fi
43-
conda install -y -c conda-forge "numpy >=${NUMPY_MIN_VER}"
4439
conda env update --file "${this_dir}/environment.yml" --prune

0 commit comments

Comments
 (0)