Skip to content

Ignore hidden files in datasets.ImageFolder? #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lopuhin opened this issue Mar 17, 2017 · 3 comments
Closed

Ignore hidden files in datasets.ImageFolder? #109

lopuhin opened this issue Mar 17, 2017 · 3 comments

Comments

@lopuhin
Copy link
Contributor

lopuhin commented Mar 17, 2017

For example, OS X likes to create .DS_Store files and they confuse datasets.ImageFolder (more precisely, the find_classes function) - it thinks this is one of the classes. Maybe it makes sense to ignore hidden files when determining classes that are present in a folder, what do you think? This particular case can also be solved if only directories were considered, not sure if it's ok to just skip regular files.

@lopuhin
Copy link
Contributor Author

lopuhin commented Mar 17, 2017

Although with #100 it is maybe less important

@daavoo
Copy link
Contributor

daavoo commented Mar 21, 2017

I found the same problem.

This is fixed in this commit: c0a6cfe

But this is not included in 0.1.7 release. Installing from source includes the commit and solve the problem

@lopuhin
Copy link
Contributor Author

lopuhin commented Mar 21, 2017

Ah, so it's fixed already, great!

@lopuhin lopuhin closed this as completed Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants