Skip to content

torchvision.transforms Images are incorrect #4486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxVanDijck opened this issue Sep 26, 2021 · 6 comments · Fixed by #4505
Closed

torchvision.transforms Images are incorrect #4486

MaxVanDijck opened this issue Sep 26, 2021 · 6 comments · Fixed by #4505

Comments

@MaxVanDijck
Copy link

📚 The doc issue

All the example astronaut images on https://pytorch.org/vision/stable/transforms.html show the same pad transform as shown:

image

image

image

Suggest a potential alternative/fix

Images should be changed to images that show the correct transforms

@MaxVanDijck MaxVanDijck changed the title torchvision.transforms torchvision.transforms Images are incorrect Sep 26, 2021
@NicolasHug
Copy link
Member

Thanks for the report @MaxVanDijck

The things you're showing aren't supposed to represent the specfic image transformations, they are just thumbnails that link to the example where each transformation is illustrated in more details.

I don't think sphinx-gallery supports having different thumbnails for different backlinks, that would involve a lot of manual work that we would prefer to avoid anyway. We can however change the thumbnail to make it more obvious https://sphinx-gallery.github.io/stable/configuration.html#choosing-the-thumbnail-image. I'm not sure which one would be best though. Perhaps the GrayScale image one, as it's bigger? (https://pytorch.org/vision/stable/auto_examples/plot_transforms.html#grayscale)

If you have a better idea we're all ear :)
Feel free to submit a PR as well if you're interested!

@MaxVanDijck
Copy link
Author

MaxVanDijck commented Sep 28, 2021

@NicolasHug Maybe rather than showing one specific transform we can use another image that makes it clearer that it is linking to the gallery? Such as a larger image with multiple different transforms shown for example one like so:

Untitled

Using:
https://sphinx-gallery.github.io/stable/configuration.html#providing-an-image-for-the-thumbnail-image

@NicolasHug
Copy link
Member

That sounds great @MaxVanDijck !

@NicolasHug
Copy link
Member

@MaxVanDijck just making sure, would you like to submit a PR for this, or are you OK for us to let someone else grab it? We're not in a rush so if you want to do it we can definitely wait a few days if needed

@MaxVanDijck
Copy link
Author

@NicolasHug You can let anyone grab this issue!

@kingyiusuen
Copy link
Contributor

I'd like to give this a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants