Skip to content

Revamping our Quantized models docs #5987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6 tasks done
NicolasHug opened this issue May 11, 2022 · 15 comments
Closed
6 tasks done

Revamping our Quantized models docs #5987

NicolasHug opened this issue May 11, 2022 · 15 comments

Comments

@NicolasHug
Copy link
Member

NicolasHug commented May 11, 2022

We're re-writing our models docs to make them clearer, simpler, and to properly document the upcoming multi-weight API. This issue is about adding docs for the Quantized classification models.

Our latest new docs are currently here (this link is likely outdated by the time you look at it, but it doesn't matter; the skeleton is there). We created a separate section that will eventually be merged into the main one. We have documented a few models, but most of them are still missing. The list of models that still need docs is listed below. If you'd like to participate, please comment below with a message saying "I'm working on XYZ" where XYZ is a model, so that others don't pick the same as you do. To keep things simple, please submit one PR per model, but feel free to contribute more than one model.

How to write docs for a model

Note: below are detailed instructions. This makes it look more complicated than it actually is. Don't be scared!

A great place to start is to look a the changes in this PR that documents SqueezeNet. You'll need to do exactly the same for your model:

To build the docs locally, please look at our contributing guide. You won't need to worry about the gallery example, so always use make html-noplot instead of make html to save time.

Please don't hesitate to ping us if you need any help / guidance or if you have any question!


Quantized models that need docs are:

@NicolasHug
Copy link
Member Author

CC @yassineAlouini as you were intersted!

@datumbox
Copy link
Contributor

@NicolasHug good call, let's get those final models done and add any remaining info. :)

Since our next release is not too far away and we got lots of work to do still on the documentation, I'll be cheeky and tag some of our good usual suspects in case they can give us a hand and get this done faster: @oke-aditya @lezwon @zhiqwang @abhi-glitchhg @xiaohu2015 @frgfm. Don't feel obliged, just a ping in case you have time.

@zhiqwang
Copy link
Contributor

Hi @NicolasHug and @datumbox ,

I would like to take ShuffleNet v2.

@xiaohu2015
Copy link
Contributor

I can take ResNet

@abhi-glitchhg
Copy link
Contributor

I can work on MobileNetV3.

@yassineAlouini
Copy link
Contributor

Inception if it is still available. 👌

@lezwon
Copy link
Contributor

lezwon commented May 12, 2022

I'll take up MobileNetV2

@frgfm
Copy link
Contributor

frgfm commented May 12, 2022

Shoot I arrived to late this time 😅
Let me know if one of you cannot do his part in the end!

@datumbox
Copy link
Contributor

@frgfm This the open-source version of music chairs: Ping more contributors than tickets and see what happens. 😄 😆

In all seriousness thanks for responding and no worries. We are very lucky to have you all supporting us like this. We got many more improvements on the pipeline coming up that we could use your help. Thanks for the support!

@NicolasHug
Copy link
Member Author

@frgfm actually I forgot Resnext and it' still up for grabs! Would you like to take it?

@datumbox
Copy link
Contributor

@zhiqwang @frgfm We are aiming to finalize the models by mid week to start preparing for the release. Let us know if you need any help with the PRs for ShuffleNetV2 and ResNeXt. If you are busy no worries, just let us know and we will pick it up or finish any incomplete PRs you might got. Thanks!

@zhiqwang
Copy link
Contributor

Hi @datumbox , I can work for ShuffleNetV2 tomorrow .

@frgfm
Copy link
Contributor

frgfm commented May 16, 2022

Happy how the musical chairs ended up haha
I'll take ResNext gladly :)

@datumbox
Copy link
Contributor

Wow I think we are done! Thanks a lot for the help!

@NicolasHug
Copy link
Member Author

<3 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants