Skip to content

ONNX CI worflow is broken #6069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #6071
pmeier opened this issue May 23, 2022 · 5 comments
Closed
Tracked by #6071

ONNX CI worflow is broken #6069

pmeier opened this issue May 23, 2022 · 5 comments

Comments

@pmeier
Copy link
Collaborator

pmeier commented May 23, 2022

Failure is visible since this morning: https://app.circleci.com/pipelines/github/pytorch/vision/17824/workflows/63ed118f-e479-47e5-91c1-2f0805ce2e5a/jobs/1443424

RuntimeError: Unsupported: ONNX export of operator prim::device, output type is not `_C.DeviceObjType`.. Please feel free to request support or submit a pull request on PyTorch GitHub.

The last commit before the weekend b969cca did not have this failure. Thus, I'm guessing we only have look for the nightlies of the 21th and 22th for possible offenders.

cc @neginraoof @seemethere

@pmeier
Copy link
Collaborator Author

pmeier commented May 23, 2022

The offender should be between pytorch/pytorch@d1bb420 and pytorch/pytorch@fbc417b inclusive.

The only PR that references ONNX is pytorch/pytorch#77423, but that seems unrelated. The only mention of DeviceObjType is in the symbolic_optset9.py module, but IIUC the only thing that changed was instead of importing directly from torch._C import DeviceObjType now we import torch._C and use it as _C.DeviceObjType.

@pmeier
Copy link
Collaborator Author

pmeier commented May 23, 2022

I bisected and it turns out pytorch/pytorch#77423 is the culprit after all @justinchuby @BowenBao

@pmeier
Copy link
Collaborator Author

pmeier commented May 23, 2022

pytorch/pytorch@0d76299 made it into the branch cut and thus we need to resolve before the release.

@justinchuby
Copy link
Contributor

@pmeier
Copy link
Collaborator Author

pmeier commented May 24, 2022

Fix worked! https://app.circleci.com/pipelines/github/pytorch/vision/17866/workflows/49b2a6cf-c54e-4c21-8a0d-a477e70c884f/jobs/1446667

Thanks @justinchuby!

@pmeier pmeier closed this as completed May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants